Skip to content

Commit f70bae8

Browse files
authored
Fix microbatch behavior flag check (#350)
1 parent 85122e5 commit f70bae8

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: Fixes
2+
body: Negate the check for microbatch behavior flag in determining builtins
3+
time: 2024-11-12T14:11:09.341634-06:00
4+
custom:
5+
Author: QMalcolm
6+
Issue: 349

dbt/adapters/base/impl.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1580,8 +1580,14 @@ def valid_incremental_strategies(self):
15801580
return ["append"]
15811581

15821582
def builtin_incremental_strategies(self):
1583+
"""
1584+
List of possible builtin strategies for adapters
1585+
1586+
Microbatch is added by _default_. It is only not added when the behavior flag
1587+
`require_batched_execution_for_custom_microbatch_strategy` is True.
1588+
"""
15831589
builtin_strategies = ["append", "delete+insert", "merge", "insert_overwrite"]
1584-
if self.behavior.require_batched_execution_for_custom_microbatch_strategy.no_warn:
1590+
if not self.behavior.require_batched_execution_for_custom_microbatch_strategy.no_warn:
15851591
builtin_strategies.append("microbatch")
15861592

15871593
return builtin_strategies

0 commit comments

Comments
 (0)