Skip to content

Fix: dbos init uses incorrect app name for GitHub templates #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

Fix: dbos init uses incorrect app name for GitHub templates #344

merged 3 commits into from
May 8, 2025

Conversation

tahsintunan
Copy link
Contributor

Fixes #273

@tahsintunan
Copy link
Contributor Author

Pinging @qianl15 because can't add you as a reviewer

@qianl15
Copy link
Member

qianl15 commented May 8, 2025 •
edited
Loading

Hi @tahsintunan thanks for your contribution! Looks like mypy reports some errors. Can you fix them and run pdm run mypy . locally to make sure your changes pass all the checks?

qianl15
qianl15 reviewed May 8, 2025
View reviewed changes
qianl15
qianl15 reviewed May 8, 2025
View reviewed changes
qianl15
qianl15 approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@qianl15 qianl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However, this PR only partially solve the issue #273
Because the initialized app code will still use the template name not the app name. We'll fix that in a separate PR.

@qianl15 qianl15 merged commit 327eb0a into dbos-inc:main May 8, 2025
5 checks passed
@tahsintunan tahsintunan deleted the fix-dbos-init branch May 8, 2025 22:00
@tahsintunan
Copy link
Contributor Author

Because the initialized app code will still use the template name not the app name.

Can you point me to where this is specified? I'm assuming it's the name field in dbos-config.yaml? Or is it programmatically defined somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qianl15 qianl15 qianl15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbos init with git imports should be able to change the app name
2 participants
@tahsintunan @qianl15