Merge pull request #528 from facultyai/button-download-prop

Add download prop to Button

Author: tcbegley

src/components/Button.js

@@ -22,6 +22,7 @@ const Button = props => {
     n_clicks,
     target,
     type,
+    download,
     ...otherProps
   } = props;
 
@@ -43,6 +44,7 @@ const Button = props => {
       target={useLink ? target : null}
       href={disabled ? null : href}
       disabled={disabled}
+      download={useLink ? download : null}
       {...omit(['n_clicks_timestamp'], otherProps)}
       data-dash-is-loading={
         (loading_state && loading_state.is_loading) || undefined
@@ -186,7 +188,12 @@ Button.propTypes = {
    * The default behavior of the button. Possible values are: button, reset,
    * submit
    */
-  type: PropTypes.oneOf(['button', 'reset', 'submit'])
+  type: PropTypes.oneOf(['button', 'reset', 'submit']),
+
+  /**
+   * Indicates that the hyperlink is to be used for downloading a resource.
+   */
+  download: PropTypes.string
 };
 
 export default Button;

src/private/Link.js

@@ -68,8 +68,10 @@ class Link extends Component {
       preOnClick,
       target,
       href,
+      download,
       ...otherProps
     } = this.props;
+    const linkIsExternal = href && isExternalLink(external_link, href);
     /**
      * ideally, we would use cloneElement however
      * that doesn't work with dash's recursive
@@ -78,7 +80,8 @@ class Link extends Component {
     return (
       <a
         href={href}
-        target={href && isExternalLink(external_link, href) ? target : null}
+        target={linkIsExternal ? target : null}
+        download={download && linkIsExternal ? download : null}
         {...otherProps}
         onClick={e => this.updateLocation(e)}
       >
@@ -136,7 +139,9 @@ Link.propTypes = {
    */
   preOnClick: PropTypes.func,
 
-  target: PropTypes.string
+  target: PropTypes.string,
+
+  download: PropTypes.string
 };
 
 Link.defaultProps = {