Remarks on the serializer rework

[Tank86]

Hi,

First of all, thanks for the v1 library, that I use on some projects and found very usefull, I did myself a couple of modificaitions in my fork.
I keep an eye on the evolution (v2) because of some devices types that I'm interested in.

Here are a couple of missing features that if possible could be added

• Add more lights features in HAlights (i'm looking especially on RGB colors)
• bring back all the variants of the setValue() from HASensors (I found super usefull also the decimal adjustment feature)

thanks,

[Tank86]

In fact while looking at the library evolution (and trying it in my current project), I see a couple of bugs. in the deserialisation of the payload for HALight brightness, Temperature, FanSpeed ...

So I fixed it in this commit Tank86@b4383bb

[Tank86]

nice fast fix,
Ah yes I missed this new deviceClass, smart way to manage floats and precision

a couple of remarks :

• https://github.com/dawidchyrzynski/arduino-home-assistant/blob/serializer-refactor/src/device-types/HASensorNumber.h#L90 states P2 as default, where is P0
• Any reason to have both setValue and SetValueFloat (and not only setValue like in v1.3) ?

[dawidchyrzynski]

Well spotted, I will update the docs. Regarding setValueFloat, it's implemented in this way to keep consistency with getter (setValueFloat, setCurrentValueFloat, getCurrentValueFloat).

Btw, if you want to browse the full documentation you can clone the repository and open the docs/index.html file in a web browser.

[dawidchyrzynski]

@Tank86, The RGB feature is already available in the HALight. Feel free to give it a go.

[Tank86]

@dawidchyrzynski, ah nice fast update.
In the mean time I also did some optimisations in my fork, i'll merge yours

I'll found also a "functional" issue, Hasensor does not send value in onMqttconnected() while HaSensorNumber did. => because the sensors have "no" values at power-on, the lib will send the default values'0' over mqtt. Which is a bit anoying,
I removed the override onMqttConnected of HaSensorNumber, that fixes the issue. see here => Tank86@68662c3

[dawidchyrzynski]

Removing the onMqttConnected method introduces another bug that may happen when HA restarts while the device is still running. Anyway, I pushed the fix for this.

[Tank86]

Looking at the RGB implementation I see that you need to do a strlen after each call of numberToStr.
Note: the strlen works only because the array is initialised with 0 before call of numberToStr.

May I suggest that the method should returns the char length, this will avoid this strlen and this will also be very usefull because the method does not set '\0' at end of char array.

[dawidchyrzynski]

Done