version 0.5.1

Author: davidegiacometti

README.md

@@ -39,6 +39,7 @@ Just download the latest release of this plugin and extract in #{RAILS_ROOT}/plu
 * **[tofi86](https://github.com/tofi86)**
 * **[loxway](https://github.com/loxway)**
 * **[kporras07](https://github.com/kporras07)**
+* **[pkonopelko](https://github.com/pkonopelko)**
 
 ## License
 Released under the MIT License.

app/views/hooks/_view_layouts_base_body_bottom.html.erb

@@ -4,9 +4,8 @@
   <% elsif Setting['text_formatting'] == 'markdown' %>
     <%= javascript_include_tag 'view_layouts_base_body_bottom_markdown', :plugin => 'redmine_shortcuts' %>
   <% end %>
-  <% if User.current.id != 2 %>
+  <% if Setting.plugin_redmine_shortcuts['enable_help_modal'] == '1' && !(Setting.login_required? and User.current.anonymous?) %>
     <%= javascript_include_tag 'view_layouts_base_body_bottom_questionmark', :plugin => 'redmine_shortcuts' %>
     <%= stylesheet_link_tag 'questionmark', :plugin => 'redmine_shortcuts', media: "all" %>
   <% end %>
-
 <% end %>

app/views/settings/_redmine_shortcuts.html.erb

@@ -3,14 +3,18 @@
   <%= check_box_tag 'settings[enable_issue_shortcuts]', '1', @settings['enable_issue_shortcuts'] %>
 </td>
 <p>
-  <label><%= l(:shortcuts_settings_enable_in_editor) %></b></label>
+  <label><%= l(:shortcuts_settings_enable_in_editor) %></label>
   <%= check_box_tag 'settings[enable_editor_shortcuts]', '1', @settings['enable_editor_shortcuts'] %>
 </p>
 <p>
-  <label><%= l(:shortcuts_settings_enable_help_link) %></b></label>
+  <label><%= l(:shortcuts_settings_enable_help_link) %></label>
   <%= check_box_tag 'settings[enable_help_link]', '1', @settings['enable_help_link'] %>
 </p>
 <p>
-  <label><%= l(:shortcuts_settings_help_link_label) %></b></label>
+  <label><%= l(:shortcuts_settings_enable_help_modal) %></label>
+  <%= check_box_tag 'settings[enable_help_modal]', '1', @settings['enable_help_modal'] %>
+</p>
+<p>
+  <label><%= l(:shortcuts_settings_help_link_label) %></label>
   <%= text_field_tag 'settings[help_link_label]', @settings['help_link_label'].blank? ? 'Shortcuts' : @settings['help_link_label'], :required => true %>
 </p>

config/locales/en.yml

@@ -3,6 +3,7 @@ en:
   shortcuts_settings_enable_in_issues: Enable issue shortcuts
   shortcuts_settings_enable_in_editor: Enable editor shortcuts
   shortcuts_settings_enable_help_link: Enable help link
+  shortcuts_settings_enable_help_modal: Enable help modal
   shortcuts_settings_help_link_label: Help link label
   shortcuts_help_title: Redmine Shortcuts Quick Reference
   shortcuts_help_issue_index: Issues index

config/locales/it.yml

@@ -3,6 +3,7 @@ it:
   shortcuts_settings_enable_in_issues: Abilita scorciatoie nelle segnalazioni
   shortcuts_settings_enable_in_editor: Abilita scorciatoie nell'editor
   shortcuts_settings_enable_help_link: Abilita link aiuto
+  shortcuts_settings_enable_help_modal: Abilita modale aiuto
   shortcuts_settings_help_link_label: Etichetta link aiuto
   shortcuts_help_title: Guida Rapida Redmine Shortcuts
   shortcuts_help_issue_index: Elenco segnalazioni

init.rb

@@ -4,11 +4,11 @@
   name 'Redmine Shortcuts'
   author 'Davide Giacometti'
   description 'Provides useful keyboard shortcuts'
-  version '0.5.0'
+  version '0.5.1'
   url 'https://github.com/davidegiacometti/redmine_shortcuts'
   author_url 'https://github.com/davidegiacometti'
 
-  settings :partial => 'settings/redmine_shortcuts', :default => {'enable_issue_shortcuts' => '1', 'enable_editor_shortcuts' => '1', 'enable_help_link' => '1', 'help_link_label' => 'Redmine shortcuts'}
+  settings :partial => 'settings/redmine_shortcuts', :default => {'enable_issue_shortcuts' => '1', 'enable_editor_shortcuts' => '1', 'enable_help_link' => '1', 'help_link_label' => 'Redmine shortcuts', 'enable_help_modal' => '1' }
 
   menu :top_menu, :redmine_shortcuts, {:controller => 'help', :action => 'index'}, :caption => Proc.new { Setting.plugin_redmine_shortcuts['help_link_label'] }, :last => true, :if => Proc.new { Setting.plugin_redmine_shortcuts['enable_help_link'] }
 end