[BUG] Build always makes doc/rofi.1 even without pandoc installed

[smarek]

Rofi version (rofi -v)

1.7.8 (git checkout tag)

Configuration

none relevant

Theme

none relevant

Timing report

No response

Launch command

make

Step to reproduce

Remove "pandoc" from your system/context

In output of "../configure --prefix=/usr/local observe following lines

--snip--

checking for pandoc... no

--snip--

-------------------------------------
Desktop File drun            Enabled
Window switcher mode         Enabled
Asan address sanitize        Disabled
Code Coverage                Disabled
Check based tests            Enabled
Build man pages              Disabled
-------------------------------------
Now type 'make' to build

In make output observe following

> make                                                                 
../script/get_git_rev.sh .. ./gitconfig.h
make  all-am
make[1]: Entering directory '/home/user/.opt/rofi/build'
../script/get_git_rev.sh .. ./gitconfig.h
make[1]: *** No rule to make target 'doc/rofi.1', needed by 'all-am'.  Stop.
make[1]: Leaving directory '/home/user/.opt/rofi/build'
make: *** [Makefile:2035: all] Error 2

Expected behavior

build should pass even without pandoc, and there should be no active "doc/*" target in Makefiles

Actual behavior

build fails

Additional information

No response

Using wayland display server protocol

• No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

• Yes, I have checked the problem exists in the latest stable version

[smarek]

Tested also with configure --disable-man, the error remains identical

make[1]: *** No rule to make target 'doc/rofi.1', needed by 'all-am'.  Stop.
make[1]: Leaving directory '/home/user/.opt/rofi/build'
make: *** [Makefile:2035: all] Error 2

[DaveDavenport]

The error message clearly states indicates it does not try to build the manpage, but fails to find the build version and does not know how to make it.

I will make pandoc mandatory, as documentation is important.

[lbonn]

@smarek @DaveDavenport if pandoc is missing, it falls back on copying the pre-built man pages which are not in git (to avoid huge diffs) but only in tarballs.

So right now the options are:

• use release tarballs
• install pandoc

[DaveDavenport]

Yeah. I want to see how I can adjust things, so a git build requires pandoc, a release not. Not sure how to best do this.
I think with meson I can do it, with auto* not sure.