[Request] Add lookup code for icon (from dekstop file) in window mode.

[DaveDavenport]

I was about to make a new request, but I guess this one is close enough.

It would be really useful if we have unified icons between drun and window in the same way that a dock, for example plank, would do. This way I am not confused when I see a different icon from what I launched.
This will greatly increase the intuitiveness of window modi.

Those docks don't use NET_WM_ICON, instead they somehow pull icon names from .desktop files even if software doesn't get launched from a .desktop file.
I don't know how they do it, maybe check plank for that.

Having the wrong icon is like typing on a new keyboard layout, it totally kills the flow.

Originally posted by @oredaze in #1935

[DaveDavenport]

If you know could you add a clear way how to get this reliably? I know I've tried this years ago, but I never got a 'nice' way to do this.

[DaveDavenport]

I notice that for way more programs then in the past the 'StartupWMClass' is correct.

[DaveDavenport]

What would be the preferred lookup logic?

Currently it is:

• _NET_WM_ICON
• WM_CLASS (lower case) lookup in icon theme.

The advantage of using _NET_WM_ICON is that the application determines what it shows there and can add extra info.
The disadvantage is you possibly get inconsistent icons.

New order should be?

• desktop file via StartWMClass?
• _NET_WM_ICON
• WM_CLASS match with desktop file?
• WM_CLASS (lower case) lookup in icon theme
  ?

This will 'change' how things behave by default for users and this always results in complaints.

[oredaze]

I didn't know that rofi has a secondary WM_CLASS lookup. That is not a bad approach for me.

The only important part is that the user is able to change the icon at will (to fix unwanted ones), as opposed to _NET_WM_ICON where the user pretty much has to dive into source code and recompile (in some cases even that is not an option, for example if you create windows with like alacritty --class Zellij -e zellij). Thus _NET_WM_ICON must not be the first on the list of lookup logics.

I suppose reversing the current order is going to be the simplest solution for you, and it would work for me too, I don't know about other people.

Maybe it is fine for everyone, if documented well somewhere up front as to avoid confusion.

I tested the WM_CLASS and it's quite painless to just create a new icon in your theme. I don't think adding new code is going to be necessary at this point.

EDIT:

• I think the most sensible thing to do from user point of view is to use Icon= from desktop files as first lookup order. I don't know the best way to match a program to desktop files.
• If that fails, do WM_CLASS (lower case)
• In third place use _NET_WM_ICON

If you don't want to do that, just reverse the current order as I said.

[DaveDavenport]

tbh I am not sure why it is preferred to ignore what the application sets as icon. I kinda prefer that.

[oredaze]

For several reasons:

• Difference between launched and running icon causes navigation issues (if you look at icon, not text. I have a theme with big icons. Icons are faster to parse visually than text)
• Icon has inconsistent style with your chosen icon theme
• Default icons are often ugly

[DaveDavenport]

Not saying I cannot see reasons, I am more trying to indicate that it is not objective, but more subjective.. So mostly worried about changing existing behavior, normally that results in some very nasty e-mails.

Also shouldn't applications obey the set icon theme? so aren't we kinda working around broken applications?

[DaveDavenport]

Should see how to make this yet another option.

[oredaze]

If this is the worry, then how about an option that is not default, that flips the lookup order, or an option to specify the order as a list?

Applications don't look at the icon theme in any way as far as I am aware (?). Maybe some do, rarely (firefox does I think). Yes, we are working around broken. Applications should just look up class name in theme. But I guess it's hard to set standards in open source. Good luck convincing the world to follow 1 thing. I also dream of for example a unified UI toolkit.

[DaveDavenport]

Good luck convincing the world to follow 1 thing. I also dream of for example a unified UI toolkit.

It has its pro and cons. From one part its good to have alternatives..

to be fair, rofi re-implements a toolkit too 🙍