fix: fixed score calculation for usage

romanlab · romanlab · commit 43cfceb5427e · 2017-12-28T10:43:07.000+02:00
diff --git a/lib/score.js b/lib/score.js
@@ -19,7 +19,7 @@ function calculatePackageScore(pkg, weights, includeUsage) {
     score += weightPercentage * pkg.score.detail.maintenance
     score += weightPercentage * pkg.score.detail.quality
   } else {
-    if (includeUsage) {
+    if (includeUsage && pkg.internalUsage) {
       score += usageWeight / weightSums * pkg.internalUsage.usage
     }
     score += popularityWeight / weightSums * pkg.score.detail.popularity

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ function calculatePackageScore(pkg, weights, includeUsage) {`
`19`	`19`	`score += weightPercentage * pkg.score.detail.maintenance`
`20`	`20`	`score += weightPercentage * pkg.score.detail.quality`
`21`	`21`	`} else {`
`22`		`- if (includeUsage) {`
	`22`	`+ if (includeUsage && pkg.internalUsage) {`
`23`	`23`	`score += usageWeight / weightSums * pkg.internalUsage.usage`
`24`	`24`	`}`
`25`	`25`	`score += popularityWeight / weightSums * pkg.score.detail.popularity`