how to extend OAuthController::callback

[okow]

Hello datamweb,

i'm starting to use your library and codeigniter as a whole, so maybe i just don't see how to reach my goal ;-)
Could you please give some advice...?

I would like to add some steps to the callback-method in case the user successfully logged in, for example sync with groups provided in the oauth-answer.
This would be at line 111 of your OAuthController.php

            // Add to default group
            $users->addToDefaultGroup($user);

How can one do this?
I don't want to change the code in vendor, since this would be overridden by future updates...

Regards
Olaf

[datamweb]

Hi Olaf,

Thanks for your question! Just to better understand your case — may I ask which OAuth provider you're using (e.g., Google, Azure AD, Facebook, etc.)?

As far as I know, Google, Yahoo, Facebook, and similar public identity providers usually do not include group information in their OAuth responses.

If you're using Google, for example, the OAuth token will contain basic user info (like name, email, profile picture), but not roles or groups.

Let me know which provider you're working with — then I can guide you on how (or if) syncing groups is possible.

[okow]

Hi,

thanks for your fast response.
I'm working on an nextcloud-provider. I could contribute it once it's finished.

Now to your question for more details: ;-)
The provider allready runs the standard-way i.e. logging the user in and, after a few tweaks with the data delivered by NC, also syncing basic user-info like fullname on first login.
The nexcloud response includes the neccessary fields as a json-object with the names of the groups the user belongs to.

      [groups] => Array ( 
        [0] => admin 
        [1] => Familie 
        [2] => Kalender etc. 
      ) 

I would put the info into a custom field of $usersColumnsName inside the custom oauth-provider so it's accessible later on.
My goal is to transfer this info thru the chained method-calls to the point where the user is logged in inside the callBack method and save it there with a call to shields method $user->syncGroups('admin', 'beta');

In the meantime i allready managed to use a copy of your original OAuthController.php by putting it into app/Controllers/OAuthController.php and adjusting the route for the call-back-URI.
Unfortunatelly it seems not to be possible to overwrite just the callback-method since it uses the other, as private declared, methods like checkAntiForgery

Would it be feasible to declare them as protected in your code, so they could be inherited instead of declared newly in the file?

Regards
Olaf

[datamweb]

Thanks a lot for the detailed explanation — and it’s great to hear that you're working on a Nextcloud provider.

Regarding your question:
Even if we change the methods like checkAntiForgery to protected, I don’t believe it would be enough to fully support a clean custom controller setup. There are likely other limitations involved, such as how routes are handled, and possibly other integration points that would require deeper changes.

That said, if you think making those methods protected would help move things forward on your side, feel free to open a PR. I’d be happy to review it and discuss possible improvements together.