Skip to content

Commit 87b4e40

Browse files
committed
code review updates
1 parent 9ff6089 commit 87b4e40

File tree

7 files changed

+47
-78
lines changed

7 files changed

+47
-78
lines changed

.github/workflows/development.yaml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ jobs:
146146
asset_path: ${{env.PKG_SDIST_PATH}}
147147
asset_name: pip-${{env.SDIST_PKG_NAME}}-${{env.PKG_VERSION}}.tar.gz
148148
asset_content_type: application/gzip
149+
# Open Source documentation deploy workflow
149150
deploy-docs:
150151
if: github.event_name == 'push'
151152
needs: build
@@ -155,16 +156,5 @@ jobs:
155156
- uses: actions/setup-python@v2
156157
with:
157158
python-version: 3.x
158-
- run: pip install mkdocs-material mkdocs-redirects mkdocstrings mkdocstrings-python # mike
159+
- run: pip install mkdocs-material mkdocs-redirects mkdocstrings mkdocstrings-python
159160
- run: mkdocs gh-deploy --force --config-file ./docs/mkdocs.yml
160-
# Mike workflow - replaces line 157. Must enable mike on line 156.
161-
# - run: |
162-
# git fetch origin gh-pages --depth=1
163-
# git config user.name {GITHUB USER}
164-
# git config user.email {GITHUB EMAIL}
165-
166-
# # Only run the first time:
167-
# mike delete --all
168-
169-
# mike deploy --push --force --update-aliases {VERSION} latest
170-
# mike set-default --push latest

docs/docker-compose-docs-serve.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# docker-compose -f docs/docker-compose-docs-serve.yaml up --build
2+
# navigate to http://localhost/
23
version: "2.4"
34
services:
45
docs:
@@ -10,12 +11,12 @@ services:
1011
volumes:
1112
- ..:/main
1213
ports:
13-
- 8080:8080
14+
- 80:80
1415
command:
1516
- bash
1617
- -c
1718
- |
1819
pwd
1920
mkdocs --version
20-
mkdocs serve --config-file ./docs/mkdocs.yml -a 0.0.0.0:8080
21-
# tail -f /dev/null
21+
mkdocs serve --config-file ./docs/mkdocs.yml -a 0.0.0.0:80
22+
# tail -f /dev/null

docs/docs.dockerfile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
FROM python:latest
1+
FROM python:slim
22

33
WORKDIR /main
4-
COPY . /main
4+
COPY ./docs /main
5+
COPY ./element_array_ephys /main
6+
COPY requirements.txt /main
7+
COPY setup.py /main
58
RUN pip install mkdocs-material mkdocs-redirects mkdocstrings mkdocstrings-python

docs/mkdocs.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
site_name: Element Array Ephys
2-
repo_url: https://github.com/A-Baji/element-array-ephys
3-
repo_name: A-Baji/element-array-ephys
2+
repo_url: https://github.com/datajoint/element-array-ephys
3+
repo_name: datajoint/element-array-ephys
44
docs_dir: ./src/
55

66
theme:
@@ -23,7 +23,7 @@ theme:
2323
name: Switch to light mode
2424

2525
nav:
26-
- Element Array Ephys: index.md
26+
- Element Array Ephys: getting_started/index.md
2727
- Getting Started:
2828
- Installation: getting_started/index.md
2929
- Set Up: getting_started/setup.md

docs/overrides/main.html

Lines changed: 0 additions & 58 deletions
This file was deleted.

docs/overrides/partials/nav.html

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
{% set class = "md-nav md-nav--primary" %}
2+
{% if "navigation.tabs" in features %}
3+
{% set class = class ~ " md-nav--lifted" %}
4+
{% endif %}
5+
{% if "toc.integrate" in features %}
6+
{% set class = class ~ " md-nav--integrated" %}
7+
{% endif %}
8+
<nav class="{{ class }}" aria-label="{{ lang.t('nav.title') }}" data-md-level="0">
9+
<label class="md-nav__title" for="__drawer">
10+
<a href="{{ config.extra.homepage | d(nav.homepage.url, true) | url }}" title="{{ config.site_name | e }}"
11+
class="md-nav__button md-logo" aria-label="{{ config.site_name }}" data-md-component="logo">
12+
{% include "partials/logo.html" %}
13+
</a>
14+
{#-
15+
Add DataJoint home link to navigation header, otherwise unchanged
16+
-#}
17+
<a href="https://www.datajoint.org/" title="DataJoint">
18+
⬅ Home
19+
</a>
20+
</label>
21+
{% if config.repo_url %}
22+
<div class="md-nav__source">
23+
{% include "partials/source.html" %}
24+
</div>
25+
{% endif %}
26+
<ul class="md-nav__list" data-md-scrollfix>
27+
{% for nav_item in nav %}
28+
{% set path = "__nav_" ~ loop.index %}
29+
{% set level = 1 %}
30+
{% include "partials/nav-item.html" %}
31+
{% endfor %}
32+
</ul>
33+
</nav>

docs/src/index.md

Whitespace-only changes.

0 commit comments

Comments
 (0)