Skip to content

Commit 11ffca3

Browse files
committed
Add a toolbox bitmap / Exclude some more There client specific code / Fix a possible registration error due to running the wrong (i.e. 64-bit) version of regsvr32.exe
1 parent c227007 commit 11ffca3

File tree

8 files changed

+29
-5
lines changed

8 files changed

+29
-5
lines changed

BrowserProxy/BrowserProxy.bmp

246 Bytes
Binary file not shown.

BrowserProxy/BrowserProxy.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -644,12 +644,14 @@ HRESULT STDMETHODCALLTYPE BrowserProxyModule::Invoke(HRESULT errorCode, ICoreWeb
644644
}
645645
).Get(), &m_windowCloseRequestedToken);
646646

647+
#ifdef THERE
647648
m_view->add_DOMContentLoaded(Callback<ICoreWebView2DOMContentLoadedEventHandler>(
648649
[this](ICoreWebView2 *sender, ICoreWebView2DOMContentLoadedEventArgs *args) -> HRESULT
649650
{
650651
return OnDOMContentLoaded(sender, args);
651652
}
652653
).Get(), &m_domContentLoadedToken);
654+
#endif
653655

654656
m_view->add_DownloadStarting(Callback<ICoreWebView2DownloadStartingEventHandler>(
655657
[this](ICoreWebView2 *sender, ICoreWebView2DownloadStartingEventArgs *args) -> HRESULT
@@ -1077,6 +1079,7 @@ HRESULT BrowserProxyModule::OnWindowCloseRequested(ICoreWebView2 *sender)
10771079
return S_OK;
10781080
}
10791081

1082+
#ifdef THERE
10801083
HRESULT BrowserProxyModule::OnDOMContentLoaded(ICoreWebView2 *sender, ICoreWebView2DOMContentLoadedEventArgs *args)
10811084
{
10821085
if (sender == nullptr || args == nullptr)
@@ -1107,6 +1110,7 @@ HRESULT BrowserProxyModule::OnDOMContentLoaded(ICoreWebView2 *sender, ICoreWebVi
11071110

11081111
return S_OK;
11091112
}
1113+
#endif
11101114

11111115
HRESULT BrowserProxyModule::OnDownloadStarting(ICoreWebView2 *sender, ICoreWebView2DownloadStartingEventArgs *args)
11121116
{
@@ -1217,6 +1221,7 @@ HRESULT BrowserProxyModule::SetVisibility(BOOL visible)
12171221
return S_OK;
12181222
}
12191223

1224+
#ifdef THERE
12201225
HRESULT BrowserProxyModule::ForwardCookie(ICoreWebView2CookieManager *cookieManager, const WCHAR *url,
12211226
const WCHAR *name, const WCHAR *domain, const WCHAR *path)
12221227
{
@@ -1284,6 +1289,7 @@ HRESULT BrowserProxyModule::ApplyScript(ICoreWebView2 *view, LONG id)
12841289

12851290
return S_OK;
12861291
}
1292+
#endif
12871293

12881294
HRESULT BrowserProxyModule::SetDeferral(ICoreWebView2NewWindowRequestedEventArgs *args)
12891295
{

BrowserProxy/BrowserProxy.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,14 +238,18 @@ class BrowserProxyModule: public CComObjectRootEx<CComSingleThreadModel>,
238238
HRESULT OnWebMessageReceived(ICoreWebView2 *sender, ICoreWebView2WebMessageReceivedEventArgs *args);
239239
#endif
240240
HRESULT OnWindowCloseRequested(ICoreWebView2 *sender);
241+
#ifdef THERE
241242
HRESULT OnDOMContentLoaded(ICoreWebView2 *sender, ICoreWebView2DOMContentLoadedEventArgs *args);
243+
#endif
242244
HRESULT OnDownloadStarting(ICoreWebView2 *sender, ICoreWebView2DownloadStartingEventArgs *args);
243245
HRESULT Navigate();
244246
HRESULT InvokeBrowserEvent(DISPID id, DISPPARAMS &args, VARIANT *result = nullptr);
245247
HRESULT SetVisibility(BOOL visible);
248+
#ifdef THERE
246249
HRESULT ForwardCookie(ICoreWebView2CookieManager *cookieManager, const WCHAR *url,
247250
const WCHAR *name, const WCHAR *domain, const WCHAR *path);
248251
HRESULT ApplyScript(ICoreWebView2 *view, LONG id);
252+
#endif
249253
HRESULT SetDeferral(ICoreWebView2NewWindowRequestedEventArgs *args);
250254
HRESULT ProcessDeferral();
251255

BrowserProxy/BrowserProxy.rc

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ END
5858
//
5959

6060
VS_VERSION_INFO VERSIONINFO
61-
FILEVERSION 1,1,2,2
62-
PRODUCTVERSION 1,1,2,2
61+
FILEVERSION 1,1,2,3
62+
PRODUCTVERSION 1,1,2,3
6363
FILEFLAGSMASK 0x3fL
6464
#ifdef _DEBUG
6565
FILEFLAGS 0x1L
@@ -76,12 +76,12 @@ BEGIN
7676
BEGIN
7777
VALUE "CompanyName", "datadiode"
7878
VALUE "FileDescription", "ActiveX proxy to Edge WebView2"
79-
VALUE "FileVersion", "1.1.2.2"
79+
VALUE "FileVersion", "1.1.2.3"
8080
VALUE "InternalName", "OpennessWebView2.dll"
8181
VALUE "LegalCopyright", "(c) Hmph! et al."
8282
VALUE "OriginalFilename", "OpennessWebView2.dll"
8383
VALUE "ProductName", "OpennessWebView2 Control"
84-
VALUE "ProductVersion", "1.1.2.2"
84+
VALUE "ProductVersion", "1.1.2.3"
8585
END
8686
END
8787
BLOCK "VarFileInfo"
@@ -99,13 +99,23 @@ END
9999
IDR_BROWSERPROXY REGISTRY "BrowserProxy.rgs"
100100

101101

102+
/////////////////////////////////////////////////////////////////////////////
103+
//
104+
// Bitmap
105+
//
106+
107+
IDR_BROWSERPROXY BITMAP "BrowserProxy.bmp"
108+
109+
102110
/////////////////////////////////////////////////////////////////////////////
103111
//
104112
// TEXTFILE
105113
//
106114

115+
#ifdef THERE
107116
IDR_COUPLING 256 "coupling.js"
108117
IDR_SETTINGS 256 "settings.html"
118+
#endif
109119

110120

111121
/////////////////////////////////////////////////////////////////////////////

BrowserProxy/BrowserProxy.rgs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ HKCR
1111
ForceRemove 'Programmable'
1212
ForceRemove 'Control'
1313
ForceRemove 'Insertable'
14+
ForceRemove 'ToolboxBitmap32' = s '%MODULE%, 101'
1415
'MiscStatus' = s '0'
1516
{
1617
'1' = s '131473'

BrowserProxy/resource.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55

66
#define IDS_PROJNAME 100
77
#define IDR_BROWSERPROXY 101
8+
#ifdef THERE
89
#define IDR_COUPLING 102
910
#define IDR_SETTINGS 103
1011

1112
#define TEXTFILE 256
13+
#endif
1214

1315
// Next default values for new objects
1416
//

Installer/MakeSFX.exe

4.5 KB
Binary file not shown.

Installer/setup.bat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@ echo BrowserExecutableFolder=%~dp0%~n2 >> OpennessWebView2.ini
66
:register
77
set options=
88
for %%x in (%*) do if /i "%%x" == "/autoextract" set options=/s
9-
regsvr32.exe %options% OpennessWebView2.dll
9+
for %%x in (system32 syswow64) do if exist "%SystemRoot%\%%x" set SystemLeaf=%%x
10+
"%SystemRoot%\%SystemLeaf%\regsvr32.exe" %options% OpennessWebView2.dll
1011
del %0

0 commit comments

Comments
 (0)