Skip to content

Commit 28922bd

Browse files
authored
Merge pull request #296 from Ryuk-me/oracle-username-as-schema
fix: oracle schema prefix
2 parents df05cd1 + e341a7c commit 28922bd

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

dcs_core/integrations/databases/bigquery.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ def query_get_table_columns(
135135
schema = schema or self.schema_name
136136
query = (
137137
"SELECT column_name, data_type, "
138-
"6 AS datetime_precision, "
139-
"38 AS numeric_precision, "
140-
"9 AS numeric_scale, "
138+
"NULL AS datetime_precision, "
139+
"NULL AS numeric_precision, "
140+
"NULL AS numeric_scale, "
141141
"NULL AS collation_name, "
142142
"NULL AS character_maximum_length "
143143
f"FROM `{self.project_id}.{schema}.INFORMATION_SCHEMA.COLUMNS` "

dcs_core/integrations/databases/oracle.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def connect(self) -> Any:
5757
"service_name": self.data_connection.get("service_name"),
5858
},
5959
)
60+
self.schema_name = self.data_connection.get("username")
6061
self.connection = engine.connect()
6162
return self.connection
6263
except Exception as e:

0 commit comments

Comments
 (0)