Skip to content

Commit f642ea4

Browse files
committed
fix merge issues
1 parent 27beade commit f642ea4

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/databricks/labs/ucx/sequencing/sequencing.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ def as_step(self, step_number: int, required_step_ids: list[int]) -> MigrationSt
5050

5151
class MigrationSequencer:
5252

53-
def __init__(self, ws: WorkspaceClient):
53+
def __init__(self, ws: WorkspaceClient, admin_locator: AdministratorLocator):
5454
self._ws = ws
55+
self._admin_locator = admin_locator
5556
self._last_node_id = 0
5657
self._nodes: dict[tuple[str, str], MigrationNode] = {}
5758
self._incoming: dict[tuple[str, str], set[tuple[str, str]]] = defaultdict(set)

tests/unit/sequencing/test_sequencing.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
from databricks.sdk.service import jobs
1+
from unittest.mock import create_autospec
2+
3+
from databricks.sdk.service import iam, jobs
24
from databricks.sdk.service.compute import ClusterDetails
35

6+
from databricks.labs.ucx.framework.owners import AdministratorLocator, AdministratorFinder
47
from databricks.labs.ucx.sequencing.sequencing import MigrationSequencer
58
from databricks.labs.ucx.source_code.base import CurrentSessionState
69
from databricks.labs.ucx.source_code.graph import DependencyGraph
@@ -15,7 +18,10 @@ def test_cluster_from_task_has_children(ws, simple_dependency_resolver, mock_pat
1518
ws.jobs.get.return_value = job
1619
dependency = WorkflowTask(ws, task, job)
1720
graph = DependencyGraph(dependency, None, simple_dependency_resolver, mock_path_lookup, CurrentSessionState())
18-
sequencer = MigrationSequencer(ws)
21+
admin_finder = create_autospec(AdministratorFinder)
22+
admin_user = iam.User(user_name="John Doe", active=True, roles=[iam.ComplexValue(value="account_admin")])
23+
admin_finder.find_admin_users.return_value = (admin_user,)
24+
sequencer = MigrationSequencer(ws, AdministratorLocator(ws, finders=[lambda _ws: admin_finder]))
1925
sequencer.register_workflow_task(task, job, graph)
2026
steps = list(sequencer.generate_steps())
2127
step = steps[-1]

0 commit comments

Comments
 (0)