Skip to content

Commit 73b277a

Browse files
ericvergnaudJCZuurmond
authored andcommitted
fix incorrect step sequence
1 parent c6fb616 commit 73b277a

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/databricks/labs/ucx/sequencing/sequencing.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,16 @@ def _visit_dependency(self, graph: DependencyGraph) -> bool | None:
104104

105105
def register_dependency(self, parent_node: MigrationNode, object_type: str, object_id: str) -> MigrationNode:
106106
dependency_node = self._nodes.get((object_type, object_id), None)
107-
if dependency_node:
108-
return dependency_node
107+
if not dependency_node:
108+
dependency_node = self._create_dependency_node(object_type, object_id)
109+
if parent_node:
110+
self._incoming[parent_node.key].add(dependency_node.key)
111+
self._outgoing[dependency_node.key].add(parent_node.key)
112+
return dependency_node
113+
114+
def _create_dependency_node(self, object_type: str, object_id: str) -> MigrationNode:
109115
object_name: str = "<ANONYMOUS>"
110-
object_owner: str = "<UNKNOWN>"
116+
_object_owner: str = "<UNKNOWN>"
111117
if object_type in {"NOTEBOOK", "FILE"}:
112118
path = Path(object_id)
113119
for library_root in self._path_lookup.library_roots:
@@ -127,8 +133,6 @@ def register_dependency(self, parent_node: MigrationNode, object_type: str, obje
127133
object_owner=object_owner,
128134
)
129135
self._nodes[dependency_node.key] = dependency_node
130-
self._incoming[dependency_node.key].add(parent_node.key)
131-
self._outgoing[parent_node.key].add(dependency_node.key)
132136
return dependency_node
133137

134138
def register_workflow_job(self, job: jobs.Job) -> MigrationNode:

0 commit comments

Comments
 (0)