Fix some nits missed from the PR comments (#4210)

Quick PR to fix some nits that were missed from PR from
#4209

Author: pritishpai

src/databricks/labs/ucx/install.py

@@ -634,7 +634,6 @@ def _handle_existing_dashboard(self, dashboard_id: str, display_name: str, paren
         return dashboard_id  # Update the existing dashboard
 
     def _is_redash_dashboard(self, dashboard_id: str) -> bool:
-        """Check if the dashboard is a Redash dashboard"""
         return "-" in dashboard_id
 
     def _upgrade_redash_dashboard(self, dashboard_id: str, display_name: str) -> None:
@@ -646,9 +645,10 @@ def _upgrade_redash_dashboard(self, dashboard_id: str, display_name: str) -> Non
 
     def _is_trashed_dashboard(self, dashboard, display_name: str, dashboard_id: str) -> bool:
         if dashboard.lifecycle_state is None:
-            raise NotFound(f"Dashboard life cycle state: {display_name} ({dashboard_id})")
+            msg = f"Dashboard life cycle state: {display_name} ({dashboard_id})"
+            raise NotFound(msg)
         if dashboard.lifecycle_state == LifecycleState.TRASHED:
-            logger.info(f"Recreating trashed dashboard: {display_name} ({dashboard_id})")
+            logger.info(f"Dashboard life cycle in trashed state: {display_name} ({dashboard_id})")
             return True
         return False
 

tests/unit/install/test_install_dashboards.py

@@ -119,7 +119,7 @@ def test_installation_recreates_trashed_lakeview_dashboard(caplog, ws, workspace
     ws.lakeview.get.return_value = LakeviewDashboard(lifecycle_state=LifecycleState.TRASHED)
     with caplog.at_level(logging.INFO, logger="databricks.labs.ucx.install"):
         workspace_installation.run()
-    assert "Recreating trashed dashboard" in caplog.text
+    assert "Dashboard life cycle in trashed state" in caplog.text
     ws.lakeview.create.assert_called()
     ws.lakeview.update.assert_not_called()