Skip to content

Commit 522f48a

Browse files
authored
[TECH DEBT] Code clean up in cluster module (#3089)
Some clean up coming out of #3081
1 parent dbb6b9c commit 522f48a

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/databricks/labs/ucx/assessment/clusters.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -215,20 +215,22 @@ def __init__(self, ws: WorkspaceClient, sql_backend: SqlBackend, schema):
215215
self._ws = ws
216216

217217
def _crawl(self) -> Iterable[PolicyInfo]:
218-
all_policices = list(self._ws.cluster_policies.list())
219-
return list(self._assess_policies(all_policices))
218+
all_policies = list(self._ws.cluster_policies.list())
219+
return list(self._assess_policies(all_policies))
220220

221-
def _assess_policies(self, all_policices) -> Iterable[PolicyInfo]:
222-
for policy in all_policices:
221+
def _assess_policies(self, all_policies: Iterable[Policy]) -> Iterable[PolicyInfo]:
222+
for policy in all_policies:
223223
failures: list[str] = []
224224
if policy.policy_id is None:
225225
continue
226226
failures.extend(self._check_cluster_policy(policy.policy_id, "policy"))
227-
try:
228-
spark_version = json.dumps(json.loads(policy.definition)["spark_version"])
229-
except KeyError:
230-
spark_version = None
231-
policy_name = policy.name
227+
spark_version = None
228+
if policy.definition is not None:
229+
try:
230+
spark_version = json.dumps(json.loads(policy.definition)["spark_version"])
231+
except KeyError:
232+
pass
233+
policy_name = policy.name or "UNDEFINED"
232234
creator_name = policy.creator_user_name or None
233235

234236
policy_info = PolicyInfo(

0 commit comments

Comments
 (0)