Use set for membership test

Author: pritishpai

src/databricks/labs/ucx/assessment/workflows.py

@@ -21,15 +21,15 @@ def crawl_tables(self, ctx: RuntimeContext):
         `$inventory_database.tables`. Note that the `inventory_database` is set in the configuration file. The metadata
         stored is then used in the subsequent tasks and workflows to, for example, find all Hive Metastore tables that
         cannot easily be migrated to Unity Catalog."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.tables_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
     def crawl_udfs(self, ctx: RuntimeContext):
         """Iterates over all UDFs in the Hive Metastore of the current workspace and persists their metadata in the
         table named `$inventory_database.udfs`. This inventory is currently used when scanning securable objects for
         issues with grants that cannot be migrated to Unit Catalog."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.udfs_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task(job_cluster="tacl")
@@ -45,7 +45,7 @@ def crawl_grants(self, ctx: RuntimeContext):
 
         Note: This job runs on a separate cluster (named `tacl`) as it requires the proper configuration to have the Table
         ACLs enabled and available for retrieval."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.grants_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task(depends_on=[crawl_tables])
@@ -54,7 +54,7 @@ def estimate_table_size_for_migration(self, ctx: RuntimeContext):
         "synced". These tables will have to be cloned in the migration process.
         Assesses the size of these tables and create `$inventory_database.table_size` table to list these sizes.
         The table size is a factor in deciding whether to clone these tables."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.table_size_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -65,7 +65,7 @@ def crawl_mounts(self, ctx: RuntimeContext):
 
         The assessment involves scanning the workspace to compile a list of all existing mount points and subsequently
         storing this information in the `$inventory.mounts` table. This is crucial for planning the migration."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.mounts_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task(depends_on=[crawl_mounts, crawl_tables])
@@ -78,7 +78,7 @@ def guess_external_locations(self, ctx: RuntimeContext):
           - Extracting all the locations associated with tables that do not use DBFS directly, but a mount point instead
           - Scanning all these locations to identify folders that can act as shared path prefixes
           - These identified external locations will be created subsequently prior to the actual table migration"""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.external_locations.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -92,7 +92,7 @@ def assess_jobs(self, ctx: RuntimeContext):
           - Clusters with incompatible Spark config tags
           - Clusters referencing DBFS locations in one or more config options
         """
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.jobs_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -106,7 +106,7 @@ def assess_clusters(self, ctx: RuntimeContext):
           - Clusters with incompatible spark config tags
           - Clusters referencing DBFS locations in one or more config options
         """
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.clusters_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -120,7 +120,7 @@ def assess_pipelines(self, ctx: RuntimeContext):
 
         Subsequently, a list of all the pipelines with matching configurations are stored in the
         `$inventory.pipelines` table."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.pipelines_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -134,7 +134,7 @@ def assess_incompatible_submit_runs(self, ctx: RuntimeContext):
         It also combines several submit runs under a single pseudo_id based on hash of the submit run configuration.
         Subsequently, a list of all the incompatible runs with failures are stored in the
         `$inventory.submit_runs` table."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.submit_runs_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -146,7 +146,7 @@ def crawl_cluster_policies(self, ctx: RuntimeContext):
 
           Subsequently, a list of all the policies with matching configurations are stored in the
         `$inventory.policies` table."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.policies_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task(cloud="azure")
@@ -161,7 +161,7 @@ def assess_azure_service_principals(self, ctx: RuntimeContext):
         Subsequently, the list of all the Azure Service Principals referred in those configurations are saved
         in the `$inventory.azure_service_principals` table."""
         if ctx.is_azure:
-            force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+            force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
             ctx.azure_service_principal_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -171,7 +171,7 @@ def assess_global_init_scripts(self, ctx: RuntimeContext):
 
         It looks in:
           - the list of all the global init scripts are saved in the `$inventory.global_init_scripts` table."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.global_init_scripts_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
@@ -184,7 +184,7 @@ def workspace_listing(self, ctx: RuntimeContext):
         if not ctx.config.use_legacy_permission_migration:
             logger.info("Skipping workspace listing as legacy permission migration is disabled.")
             return
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.workspace_listing.snapshot(force_refresh=force_refresh)
 
     @job_task(depends_on=[crawl_grants, workspace_listing])
@@ -199,25 +199,25 @@ def crawl_permissions(self, ctx: RuntimeContext):
             return
         permission_manager = ctx.permission_manager
         permission_manager.reset()
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         permission_manager.snapshot(force_refresh=force_refresh)
 
     @job_task
     def crawl_groups(self, ctx: RuntimeContext):
         """Scans all groups for the local group migration scope"""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.group_manager.snapshot(force_refresh=force_refresh)
 
     @job_task
     def crawl_redash_dashboards(self, ctx: RuntimeContext):
         """Scans all Redash dashboards."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.redash_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task
     def crawl_lakeview_dashboards(self, ctx: RuntimeContext):
         """Scans all Lakeview dashboards."""
-        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in ["true", "1"]
+        force_refresh = ctx.named_parameters.get("force_refresh", "False").lower() in {"true", "1"}
         ctx.lakeview_crawler.snapshot(force_refresh=force_refresh)
 
     @job_task(depends_on=[crawl_redash_dashboards, crawl_lakeview_dashboards])