From 8703393f16e88311c200ed7d53385bb2220ebf6e Mon Sep 17 00:00:00 2001 From: Levko Kravets Date: Thu, 11 Jul 2024 17:47:00 +0300 Subject: [PATCH] Fix CloudFetch retry policy to be compatible with all `urllib3` versions we support Signed-off-by: Levko Kravets --- src/databricks/sql/cloudfetch/downloader.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/databricks/sql/cloudfetch/downloader.py b/src/databricks/sql/cloudfetch/downloader.py index 61ae26ac5..3b1e01263 100644 --- a/src/databricks/sql/cloudfetch/downloader.py +++ b/src/databricks/sql/cloudfetch/downloader.py @@ -17,7 +17,9 @@ retryPolicy = Retry( total=5, # max retry attempts backoff_factor=1, # min delay, 1 second - backoff_max=60, # max delay, 60 seconds + # TODO: `backoff_max` is supported since `urllib3` v2.0.0, but we allow >= 1.26. + # The default value (120 seconds) used since v1.26 looks reasonable enough + # backoff_max=60, # max delay, 60 seconds # retry all status codes below 100, 429 (Too Many Requests), and all codes above 500, # excluding 501 Not implemented status_forcelist=[*range(0, 101), 429, 500, *range(502, 1000)],