Skip to content

Commit df9f849

Browse files
add spec to description extraction docstring, add strong typing to params
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 5c1166a commit df9f849

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/databricks/sql/backend/sea/backend.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
22
import time
33
import re
4-
from typing import Dict, Tuple, List, Optional, Union, TYPE_CHECKING, Set
4+
from typing import Any, Dict, Tuple, List, Optional, Union, TYPE_CHECKING, Set
55

66
from databricks.sql.backend.sea.models.base import ResultManifest
77
from databricks.sql.backend.sea.utils.constants import (
@@ -286,10 +286,11 @@ def _extract_description_from_manifest(
286286
self, manifest: ResultManifest
287287
) -> Optional[List]:
288288
"""
289-
Extract column description from a manifest object.
289+
Extract column description from a manifest object, in the format defined by
290+
the spec: https://peps.python.org/pep-0249/#description
290291
291292
Args:
292-
manifest_obj: The ResultManifest object containing schema information
293+
manifest: The ResultManifest object containing schema information
293294
294295
Returns:
295296
Optional[List]: A list of column tuples or None if no columns are found
@@ -397,7 +398,7 @@ def execute_command(
397398
lz4_compression: bool,
398399
cursor: "Cursor",
399400
use_cloud_fetch: bool,
400-
parameters: List,
401+
parameters: List[Dict[str, Any]],
401402
async_op: bool,
402403
enforce_embedded_schema_correctness: bool,
403404
) -> Union["ResultSet", None]:

0 commit comments

Comments
 (0)