Skip to content

Commit 7343035

Browse files
remove un-necessary timestamp tests
(pass with minor disparity) Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent c0e98f4 commit 7343035

File tree

1 file changed

+4
-39
lines changed

1 file changed

+4
-39
lines changed

tests/e2e/test_driver.py

Lines changed: 4 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -496,17 +496,6 @@ def test_get_columns(self):
496496
for table in table_names:
497497
cursor.execute("DROP TABLE IF EXISTS {}".format(table))
498498

499-
@pytest.mark.parametrize(
500-
"extra_params",
501-
[
502-
{},
503-
{
504-
"use_sea": True,
505-
"use_cloud_fetch": False,
506-
"enable_query_result_lz4_compression": False,
507-
},
508-
],
509-
)
510499
def test_escape_single_quotes(self, extra_params):
511500
with self.cursor(extra_params) as cursor:
512501
table_name = "table_{uuid}".format(uuid=str(uuid4()).replace("-", "_"))
@@ -824,21 +813,8 @@ def test_ssp_passthrough(self):
824813
assert list(cursor.fetchone()) == ["ansi_mode", str(enable_ansi)]
825814

826815
@skipUnless(pysql_supports_arrow(), "arrow test needs arrow support")
827-
@pytest.mark.parametrize(
828-
"extra_params",
829-
[
830-
{},
831-
{
832-
"use_sea": True,
833-
"use_cloud_fetch": False,
834-
"enable_query_result_lz4_compression": False,
835-
},
836-
],
837-
)
838-
def test_timestamps_arrow(self, extra_params):
839-
with self.cursor(
840-
{"session_configuration": {"ansi_mode": False}, **extra_params}
841-
) as cursor:
816+
def test_timestamps_arrow(self):
817+
with self.cursor({"session_configuration": {"ansi_mode": False}}) as cursor:
842818
for timestamp, expected in self.timestamp_and_expected_results:
843819
cursor.execute(
844820
"SELECT TIMESTAMP('{timestamp}')".format(timestamp=timestamp)
@@ -892,20 +868,9 @@ def test_multi_timestamps_arrow(self, extra_params):
892868
assert result == expected
893869

894870
@skipUnless(pysql_supports_arrow(), "arrow test needs arrow support")
895-
@pytest.mark.parametrize(
896-
"extra_params",
897-
[
898-
{},
899-
{
900-
"use_sea": True,
901-
"use_cloud_fetch": False,
902-
"enable_query_result_lz4_compression": False,
903-
},
904-
],
905-
)
906-
def test_timezone_with_timestamp(self, extra_params):
871+
def test_timezone_with_timestamp(self):
907872
if self.should_add_timezone():
908-
with self.cursor(extra_params) as cursor:
873+
with self.cursor() as cursor:
909874
cursor.execute("SET TIME ZONE 'Europe/Amsterdam'")
910875
cursor.execute("select CAST('2022-03-02 12:54:56' as TIMESTAMP)")
911876
amsterdam = pytz.timezone("Europe/Amsterdam")

0 commit comments

Comments
 (0)