Skip to content

Commit 4d455bb

Browse files
correct session logic after duplication during merge
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 30849dc commit 4d455bb

File tree

3 files changed

+7
-17
lines changed

3 files changed

+7
-17
lines changed

src/databricks/sql/backend/thrift_backend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ def execute_command(
939939
logger.debug(
940940
"ThriftBackend.execute_command(operation=%s, session_handle=%s)",
941941
operation,
942-
session_handle,
942+
thrift_handle,
943943
)
944944

945945
spark_arrow_types = ttypes.TSparkArrowTypes(

src/databricks/sql/client.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -250,18 +250,6 @@ def read(self) -> Optional[OAuthToken]:
250250
+ str(self.get_session_id_hex())
251251
)
252252

253-
# Create the session
254-
self.session = Session(
255-
server_hostname,
256-
http_path,
257-
http_headers,
258-
session_configuration,
259-
catalog,
260-
schema,
261-
_use_arrow_native_complex_types,
262-
**kwargs
263-
)
264-
265253
self.use_inline_params = self._set_use_inline_params_with_warning(
266254
kwargs.get("use_inline_params", False)
267255
)

src/databricks/sql/session.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,18 @@ def __init__(
8484
**kwargs,
8585
)
8686

87+
def open(self):
8788
self._session_id = self.backend.open_session(
88-
session_configuration=session_configuration, catalog=catalog, schema=schema
89+
session_configuration=self.session_configuration,
90+
catalog=self.catalog,
91+
schema=self.schema,
8992
)
90-
9193
self.protocol_version = self.get_protocol_version(self._session_id)
92-
self.open = True
94+
self.is_open = True
9395
logger.info("Successfully opened session " + str(self.get_id_hex()))
9496

9597
@staticmethod
96-
def get_protocol_version(sessionId: SessionId):
98+
def get_protocol_version(session_id: SessionId):
9799
"""
98100
Since the sessionHandle will sometimes have a serverProtocolVersion, it takes
99101
precedence over the serverProtocolVersion defined in the OpenSessionResponse.

0 commit comments

Comments
 (0)