fix: ensure open attribute of Connection never fails

varun-edachali-dbx · varun-edachali-dbx · commit 39294e9866c2 · 2025-05-28T11:02:21.000Z
in case the openSession takes long, the initialisation of the session
will not complete immediately. This could make the session attribute
inaccessible. If the Connection is deleted in this time, the open()
check will throw because the session attribute does not exist. Thus, we
default to the Connection being closed in this case. This was not an
issue before because open was a direct attribute of the Connection
class. Caught in the integration tests.

Signed-off-by: varun-edachali-dbx &lt;varun.edachali@databricks.com&gt;
diff --git a/src/databricks/sql/client.py b/src/databricks/sql/client.py
@@ -19,8 +19,6 @@
     OperationalError,
     SessionAlreadyClosedError,
     CursorAlreadyClosedError,
-    Error,
-    NotSupportedError,
 )
 from databricks.sql.thrift_api.TCLIService import ttypes
 from databricks.sql.backend.thrift_backend import ThriftDatabricksClient

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@`
`19`	`19`	`OperationalError,`
`20`	`20`	`SessionAlreadyClosedError,`
`21`	`21`	`CursorAlreadyClosedError,`
`22`		`- Error,`
`23`		`- NotSupportedError,`
`24`	`22`	`)`
`25`	`23`	`from databricks.sql.thrift_api.TCLIService import ttypes`
`26`	`24`	`from databricks.sql.backend.thrift_backend import ThriftDatabricksClient`