n_valid_rows -> num_rows

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

Author: varun-edachali-dbx

src/databricks/sql/utils.py

@@ -118,7 +118,6 @@ def build_queue(
         manifest: Optional[ResultManifest],
         statement_id: str,
         description: List[Tuple] = [],
-        schema_bytes: Optional[bytes] = None,
         max_download_threads: Optional[int] = None,
         sea_client: Optional[SeaDatabricksClient] = None,
         lz4_compressed: bool = False,
@@ -141,6 +140,7 @@ def build_queue(
             ResultSetQueue: The appropriate queue for the result data
         """
 
+        print(sea_result_data)
         if sea_result_data.data is not None:
             # INLINE disposition with JSON_ARRAY format
             return JsonQueue(sea_result_data.data)
@@ -159,11 +159,11 @@ def __init__(self, data_array):
         """Initialize with JSON array data."""
         self.data_array = data_array
         self.cur_row_index = 0
-        self.n_valid_rows = len(data_array)
+        self.num_rows = len(data_array)
 
     def next_n_rows(self, num_rows):
         """Get the next n rows from the data array."""
-        length = min(num_rows, self.n_valid_rows - self.cur_row_index)
+        length = min(num_rows, self.num_rows - self.cur_row_index)
         slice = self.data_array[self.cur_row_index : self.cur_row_index + length]
         self.cur_row_index += length
         return slice

tests/unit/test_sea_queue.py

@@ -30,7 +30,7 @@ def test_init(self, sample_data):
         queue = JsonQueue(sample_data)
         assert queue.data_array == sample_data
         assert queue.cur_row_index == 0
-        assert queue.n_valid_rows == len(sample_data)
+        assert queue.num_rows == len(sample_data)
 
     def test_next_n_rows_partial(self, sample_data):
         """Test fetching a subset of rows."""
@@ -82,7 +82,7 @@ def test_empty_data(self):
         assert queue.next_n_rows(10) == []
         assert queue.remaining_rows() == []
         assert queue.cur_row_index == 0
-        assert queue.n_valid_rows == 0
+        assert queue.num_rows == 0
 
 
 class TestSeaResultSetQueueFactory:
@@ -130,7 +130,7 @@ def test_build_queue_with_inline_data(self, mock_sea_client, mock_description):
         # Verify the queue is a JsonQueue with the correct data
         assert isinstance(queue, JsonQueue)
         assert queue.data_array == data
-        assert queue.n_valid_rows == len(data)
+        assert queue.num_rows == len(data)
 
     def test_build_queue_with_empty_data(self, mock_sea_client, mock_description):
         """Test building a queue with empty data."""
@@ -149,7 +149,7 @@ def test_build_queue_with_empty_data(self, mock_sea_client, mock_description):
         # Verify the queue is a JsonQueue with empty data
         assert isinstance(queue, JsonQueue)
         assert queue.data_array == []
-        assert queue.n_valid_rows == 0
+        assert queue.num_rows == 0
 
     def test_build_queue_with_external_links(self, mock_sea_client, mock_description):
         """Test building a queue with external links raises NotImplementedError."""

tests/unit/test_sea_result_set.py

@@ -194,7 +194,7 @@ def test_init_with_result_data(self, result_set_with_data, sample_data):
         # Verify the results queue was created correctly
         assert isinstance(result_set_with_data.results, JsonQueue)
         assert result_set_with_data.results.data_array == sample_data
-        assert result_set_with_data.results.n_valid_rows == len(sample_data)
+        assert result_set_with_data.results.num_rows == len(sample_data)
 
     def test_convert_json_types(self, result_set_with_data, sample_data):
         """Test the _convert_json_types method."""