Skip to content

Commit 27158b1

Browse files
remove un-ncessary verbose mocking
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent e96a078 commit 27158b1

File tree

1 file changed

+5
-70
lines changed

1 file changed

+5
-70
lines changed

tests/unit/test_thrift_backend.py

Lines changed: 5 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,20 +1175,7 @@ def test_execute_statement_calls_client_and_handle_execute_response(
11751175
auth_provider=AuthProvider(),
11761176
ssl_options=SSLOptions(),
11771177
)
1178-
thrift_backend._handle_execute_response = Mock(
1179-
return_value=Mock(
1180-
spec=ExecuteResponse,
1181-
command_id=Mock(),
1182-
status=Mock(),
1183-
description=Mock(),
1184-
has_more_rows=Mock(),
1185-
results_queue=Mock(),
1186-
has_been_closed_server_side=Mock(),
1187-
lz4_compressed=Mock(),
1188-
is_staging_operation=Mock(),
1189-
arrow_schema_bytes=Mock(),
1190-
)
1191-
)
1178+
thrift_backend._handle_execute_response = Mock()
11921179
cursor_mock = Mock()
11931180

11941181
result = thrift_backend.execute_command(
@@ -1222,20 +1209,7 @@ def test_get_catalogs_calls_client_and_handle_execute_response(
12221209
auth_provider=AuthProvider(),
12231210
ssl_options=SSLOptions(),
12241211
)
1225-
thrift_backend._handle_execute_response = Mock(
1226-
return_value=Mock(
1227-
spec=ExecuteResponse,
1228-
command_id=Mock(),
1229-
status=Mock(),
1230-
description=Mock(),
1231-
has_more_rows=Mock(),
1232-
results_queue=Mock(),
1233-
has_been_closed_server_side=Mock(),
1234-
lz4_compressed=Mock(),
1235-
is_staging_operation=Mock(),
1236-
arrow_schema_bytes=Mock(),
1237-
)
1238-
)
1212+
thrift_backend._handle_execute_response = Mock()
12391213
cursor_mock = Mock()
12401214

12411215
result = thrift_backend.get_catalogs(Mock(), 100, 200, cursor_mock)
@@ -1266,20 +1240,7 @@ def test_get_schemas_calls_client_and_handle_execute_response(
12661240
auth_provider=AuthProvider(),
12671241
ssl_options=SSLOptions(),
12681242
)
1269-
thrift_backend._handle_execute_response = Mock(
1270-
return_value=Mock(
1271-
spec=ExecuteResponse,
1272-
command_id=Mock(),
1273-
status=Mock(),
1274-
description=Mock(),
1275-
has_more_rows=Mock(),
1276-
results_queue=Mock(),
1277-
has_been_closed_server_side=Mock(),
1278-
lz4_compressed=Mock(),
1279-
is_staging_operation=Mock(),
1280-
arrow_schema_bytes=Mock(),
1281-
)
1282-
)
1243+
thrift_backend._handle_execute_response = Mock()
12831244
cursor_mock = Mock()
12841245

12851246
result = thrift_backend.get_schemas(
@@ -1319,20 +1280,7 @@ def test_get_tables_calls_client_and_handle_execute_response(
13191280
auth_provider=AuthProvider(),
13201281
ssl_options=SSLOptions(),
13211282
)
1322-
thrift_backend._handle_execute_response = Mock(
1323-
return_value=Mock(
1324-
spec=ExecuteResponse,
1325-
command_id=Mock(),
1326-
status=Mock(),
1327-
description=Mock(),
1328-
has_more_rows=Mock(),
1329-
results_queue=Mock(),
1330-
has_been_closed_server_side=Mock(),
1331-
lz4_compressed=Mock(),
1332-
is_staging_operation=Mock(),
1333-
arrow_schema_bytes=Mock(),
1334-
)
1335-
)
1283+
thrift_backend._handle_execute_response = Mock()
13361284
cursor_mock = Mock()
13371285

13381286
result = thrift_backend.get_tables(
@@ -1376,20 +1324,7 @@ def test_get_columns_calls_client_and_handle_execute_response(
13761324
auth_provider=AuthProvider(),
13771325
ssl_options=SSLOptions(),
13781326
)
1379-
thrift_backend._handle_execute_response = Mock(
1380-
return_value=Mock(
1381-
spec=ExecuteResponse,
1382-
command_id=Mock(),
1383-
status=Mock(),
1384-
description=Mock(),
1385-
has_more_rows=Mock(),
1386-
results_queue=Mock(),
1387-
has_been_closed_server_side=Mock(),
1388-
lz4_compressed=Mock(),
1389-
is_staging_operation=Mock(),
1390-
arrow_schema_bytes=Mock(),
1391-
)
1392-
)
1327+
thrift_backend._handle_execute_response = Mock()
13931328
cursor_mock = Mock()
13941329

13951330
result = thrift_backend.get_columns(

0 commit comments

Comments
 (0)