Skip to content

Commit 1e5f2eb

Browse files
committed
added back random test, connection debug
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
1 parent 52b6019 commit 1e5f2eb

File tree

2 files changed

+32
-31
lines changed

2 files changed

+32
-31
lines changed

src/databricks/sql/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ def read(self) -> Optional[OAuthToken]:
305305
self.use_inline_params = self._set_use_inline_params_with_warning(
306306
kwargs.get("use_inline_params", False)
307307
)
308-
308+
print("Connection init : session_id_hex", self.get_session_id_hex(), flush=True)
309309
TelemetryClientFactory.initialize_telemetry_client(
310310
telemetry_enabled=self.telemetry_enabled,
311311
session_id_hex=self.get_session_id_hex(),
@@ -440,6 +440,7 @@ def cursor(
440440

441441
def close(self) -> None:
442442
"""Close the underlying session and mark all associated cursors as closed."""
443+
print("Connection close: session_id_hex: ", self.get_session_id_hex(), flush=True)
443444
self._close()
444445

445446
def _close(self, close_cursors=True) -> None:

tests/unit/test_client.py

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -650,36 +650,36 @@ def test_disable_pandas_respected(self, mock_thrift_backend_class):
650650

651651
mock_table.itercolumns.assert_called_once_with()
652652

653-
# def test_column_name_api(self):
654-
# ResultRow = Row("first_col", "second_col", "third_col")
655-
# data = [
656-
# ResultRow("val1", 321, 52.32),
657-
# ResultRow("val2", 2321, 252.32),
658-
# ]
659-
660-
# expected_values = [["val1", 321, 52.32], ["val2", 2321, 252.32]]
661-
662-
# for (row, expected) in zip(data, expected_values):
663-
# self.assertEqual(row.first_col, expected[0])
664-
# self.assertEqual(row.second_col, expected[1])
665-
# self.assertEqual(row.third_col, expected[2])
666-
667-
# self.assertEqual(row["first_col"], expected[0])
668-
# self.assertEqual(row["second_col"], expected[1])
669-
# self.assertEqual(row["third_col"], expected[2])
670-
671-
# self.assertEqual(row[0], expected[0])
672-
# self.assertEqual(row[1], expected[1])
673-
# self.assertEqual(row[2], expected[2])
674-
675-
# self.assertEqual(
676-
# row.asDict(),
677-
# {
678-
# "first_col": expected[0],
679-
# "second_col": expected[1],
680-
# "third_col": expected[2],
681-
# },
682-
# )
653+
def test_column_name_api(self):
654+
ResultRow = Row("first_col", "second_col", "third_col")
655+
data = [
656+
ResultRow("val1", 321, 52.32),
657+
ResultRow("val2", 2321, 252.32),
658+
]
659+
660+
expected_values = [["val1", 321, 52.32], ["val2", 2321, 252.32]]
661+
662+
for (row, expected) in zip(data, expected_values):
663+
self.assertEqual(row.first_col, expected[0])
664+
self.assertEqual(row.second_col, expected[1])
665+
self.assertEqual(row.third_col, expected[2])
666+
667+
self.assertEqual(row["first_col"], expected[0])
668+
self.assertEqual(row["second_col"], expected[1])
669+
self.assertEqual(row["third_col"], expected[2])
670+
671+
self.assertEqual(row[0], expected[0])
672+
self.assertEqual(row[1], expected[1])
673+
self.assertEqual(row[2], expected[2])
674+
675+
self.assertEqual(
676+
row.asDict(),
677+
{
678+
"first_col": expected[0],
679+
"second_col": expected[1],
680+
"third_col": expected[2],
681+
},
682+
)
683683

684684
@patch("%s.client.ThriftBackend" % PACKAGE_NAME)
685685
def test_finalizer_closes_abandoned_connection(self, mock_client_class):

0 commit comments

Comments
 (0)