Skip to content

Commit 10f55f0

Browse files
remove redundant conversion.py
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent b00c06c commit 10f55f0

File tree

5 files changed

+2
-144
lines changed

5 files changed

+2
-144
lines changed

src/databricks/sql/backend/sea/conversion.py

Lines changed: 0 additions & 135 deletions
This file was deleted.

src/databricks/sql/backend/sea/result_set.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
if TYPE_CHECKING:
1717
from databricks.sql.client import Connection
18-
from databricks.sql.exc import ProgrammingError
1918
from databricks.sql.types import Row
2019
from databricks.sql.backend.sea.queue import JsonQueue, SeaResultSetQueueFactory
2120
from databricks.sql.backend.types import ExecuteResponse

src/databricks/sql/result_set.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
from __future__ import annotations
22

33
from abc import ABC, abstractmethod
4-
import json
5-
from typing import List, Optional, Any, Union, Tuple, TYPE_CHECKING
4+
from typing import List, Optional, Tuple, TYPE_CHECKING
65

76
import logging
87
import pandas
98

10-
from databricks.sql.backend.sea.backend import SeaDatabricksClient
11-
from databricks.sql.backend.sea.models.base import ResultData, ResultManifest
12-
from databricks.sql.backend.sea.conversion import SqlTypeConverter
13-
149
try:
1510
import pyarrow
1611
except ImportError:

tests/unit/test_sea_backend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ def test_command_management(
482482
)
483483

484484
# Test get_query_state with invalid ID
485-
with pytest.raises(ProgrammingError) as excinfo:
485+
with pytest.raises(ValueError) as excinfo:
486486
sea_client.get_query_state(thrift_command_id)
487487
assert "Not a valid SEA command ID" in str(excinfo.value)
488488

tests/unit/test_sea_result_set.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,6 @@ def test_iteration(self, result_set_with_data, sample_data):
315315
assert rows[0].col2 == 1
316316
assert rows[0].col3 is True
317317

318-
319318
def test_is_staging_operation(
320319
self, mock_connection, mock_sea_client, execute_response
321320
):

0 commit comments

Comments
 (0)