Support http agent for non https connections (#57)

* fix: Support http agent for non https connections

Signed-off-by: Chen Zhou <i@uint0.dev>

* Update lib/connection/connections/HttpConnection.ts

Co-authored-by: Levko Kravets <levko.ne@gmail.com>

Signed-off-by: Chen Zhou <i@uint0.dev>
Co-authored-by: Levko Kravets <levko.ne@gmail.com>

Author: uint0

lib/connection/connections/HttpConnection.ts

@@ -1,7 +1,7 @@
 import thrift from 'thrift';
 import https from 'https';
 
-import { IncomingMessage } from 'http';
+import http, { IncomingMessage } from 'http';
 import IThriftConnection from '../contracts/IThriftConnection';
 import IConnectionProvider from '../contracts/IConnectionProvider';
 import IConnectionOptions, { Options } from '../contracts/IConnectionOptions';
@@ -21,12 +21,13 @@ export default class HttpConnection implements IConnectionProvider, IThriftConne
   private connection: any;
 
   connect(options: IConnectionOptions, authProvider: IAuthentication): Promise<IThriftConnection> {
+    const Agent = options.options?.https ? https.Agent : http.Agent;
     const httpTransport = new HttpTransport({
       transport: thrift.TBufferedTransport,
       protocol: thrift.TBinaryProtocol,
       ...options.options,
       nodeOptions: {
-        agent: new https.Agent({
+        agent: new Agent({
           keepAlive: true,
           maxSockets: 5,
           keepAliveMsecs: 10000,

tests/unit/connection/connections/HttpConnection.test.js

@@ -1,3 +1,4 @@
+const http = require('http');
 const { expect } = require('chai');
 const HttpConnection = require('../../../../').connections.HttpConnection;
 
@@ -161,4 +162,29 @@ describe('HttpConnection.connect', () => {
         expect(Object.keys(connection.thrift.options.nodeOptions)).to.be.deep.eq(['agent']);
       });
   });
+
+  it('should use a http agent if https is not enabled', () => {
+    const connection = new HttpConnection();
+    const authenticator = authProviderMock();
+    const resultConnection = {
+      responseCallback() {},
+    };
+    connection.thrift = thriftMock(resultConnection);
+
+    return connection
+      .connect(
+        {
+          host: 'localhost',
+          port: 10001,
+          options: {
+            https: false,
+            path: '/hive',
+          },
+        },
+        authenticator,
+      )
+      .then(() => {
+        expect(connection.thrift.options.nodeOptions.agent).to.be.instanceOf(http.Agent);
+      });
+  });
 });