Skip to content

Commit 7c301d5

Browse files
[Internal] Delete unnecessary API Client constructor (#1172)
## What changes are proposed in this pull request? This PR deletes `client.NewWithClient`, leaving `client.New` as only constructor for `DatabricksClient`. This change guarantees that `httpclient.ApiClient` can now be considered as an implementation detail of `DatabricksClient` — which enables further abstraction and code decoupling. ## How is this tested? Normal CI. NO_CHANGELOG=true
1 parent 7dc511d commit 7c301d5

File tree

21 files changed

+239
-673
lines changed

21 files changed

+239
-673
lines changed

apps/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ replace github.com/databricks/databricks-sdk-go/auth => ../auth
99
require (
1010
github.com/databricks/databricks-sdk-go/databricks v0.0.0-00010101000000-000000000000
1111
golang.org/x/exp v0.0.0-20240222234643-814bf88cf225
12+
golang.org/x/oauth2 v0.24.0
1213
)
1314

1415
require (
@@ -32,7 +33,6 @@ require (
3233
golang.org/x/crypto v0.31.0 // indirect
3334
golang.org/x/mod v0.17.0 // indirect
3435
golang.org/x/net v0.33.0 // indirect
35-
golang.org/x/oauth2 v0.25.0 // indirect
3636
golang.org/x/sys v0.28.0 // indirect
3737
golang.org/x/text v0.21.0 // indirect
3838
golang.org/x/time v0.5.0 // indirect

apps/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ golang.org/x/net v0.0.0-20201110031124-69a78807bb2b/go.mod h1:sp8m0HH+o8qH0wwXwY
9898
golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
9999
golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
100100
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
101-
golang.org/x/oauth2 v0.25.0 h1:CY4y7XT9v0cRI9oupztF8AgiIu99L/ksR/Xp/6jrZ70=
102-
golang.org/x/oauth2 v0.25.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
101+
golang.org/x/oauth2 v0.24.0 h1:KTBBxWqUa0ykRPLtV69rRto9TLXcqYkeswu48x/gvNE=
102+
golang.org/x/oauth2 v0.24.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
103103
golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
104104
golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
105105
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=

apps/v2/client.go

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)