The name style for anonymous select item

[xudong963]

Consider the following sqls

create table t(a int);
insert into t values(1),(2);
select sum(a) from t group by a;

For our old planner: the output is the following, the alias name is mysql style

sum(a)
1
2

For our new planner: the alias name will be pg style, as the code shows:

pub fn get_expr_display_string(expr: &Expr) -> String {
    match expr {
        Expr::ColumnRef { column, .. } => column.name.clone(),
        _ => {
            // TODO: this is Postgres style name for anonymous select item
            "?column?".to_string()
        }
    }

This ticket is to discuss which style we will end up with?

[leiysky]

cc @sundy-li @BohuTANG @zhang2014

[sundy-li]

I prefer to pass various dialects here to cover both names or just use MySQL style.

[leiysky]

Agree. I think MySQL style is more readable.

[Xuanwo]

Hey, let's use reactions instead of plain Agree 😆

I will hide all replies without new information attached.

[xudong963]

Mysql style passed unanimously 😂