fixes(settings): fix server hang when concurrent requests http auth

Author: zhang2014

Cargo.lock

@@ -14,6 +14,7 @@ common-config = { path = "../config" }
 common-exception = { path = "../../common/exception" }
 common-meta-types = { path = "../../meta/types" }
 common-users = { path = "../users" }
+common-base = { path = "../../common/base" }
 
 futures = "0.3.21"
 itertools = "0.10.3"

src/query/settings/Cargo.toml

@@ -22,6 +22,8 @@ use std::str;
 use std::sync::Arc;
 
 use common_ast::Dialect;
+use common_base::base::GlobalIORuntime;
+use common_base::base::TrySpawn;
 use common_config::Config;
 use common_exception::ErrorCode;
 use common_exception::Result;
@@ -88,7 +90,7 @@ impl Settings {
             for global_setting in global_settings {
                 let name = global_setting.name;
                 let val = global_setting.value.as_string()?;
-                settings.set_settings(name, val, true)?;
+                settings.set_settings(name, val, false)?;
             }
             settings
         };
@@ -546,12 +548,15 @@ impl Settings {
         setting.user_setting.value = UserSettingValue::UInt64(val);
 
         if is_global {
-            let tenant = self.tenant.as_str();
-            let _ = futures::executor::block_on(
+            let tenant = self.tenant.clone();
+            let user_setting = setting.user_setting.clone();
+            let set_handle = GlobalIORuntime::instance().spawn(async move {
                 UserApiProvider::instance()
-                    .get_setting_api_client(tenant)?
-                    .set_setting(setting.user_setting.clone()),
-            )?;
+                    .get_setting_api_client(&tenant)?
+                    .set_setting(user_setting)
+                    .await
+            });
+            let _ = futures::executor::block_on(set_handle).unwrap()?;
             setting.level = ScopeLevel::Global;
         }
 
@@ -566,11 +571,15 @@ impl Settings {
         setting.user_setting.value = UserSettingValue::String(val);
 
         if is_global {
-            let _ = futures::executor::block_on(
+            let tenant = self.tenant.clone();
+            let user_setting = setting.user_setting.clone();
+            let set_handle = GlobalIORuntime::instance().spawn(async move {
                 UserApiProvider::instance()
-                    .get_setting_api_client(&self.tenant)?
-                    .set_setting(setting.user_setting.clone()),
-            )?;
+                    .get_setting_api_client(&tenant)?
+                    .set_setting(user_setting)
+                    .await
+            });
+            let _ = futures::executor::block_on(set_handle).unwrap()?;
             setting.level = ScopeLevel::Global;
         }