feat(query): fix domain downcast error

Author: sundy-li

src/query/expression/src/types/nullable.rs

@@ -69,6 +69,14 @@ impl<T: ValueType> ValueType for NullableType<T> {
                 has_null: *has_null,
                 value: Some(Box::new(T::try_downcast_domain(value)?)),
             }),
+
+            Domain::Nullable(NullableDomain {
+                has_null,
+                value: None,
+            }) => Some(NullableDomain {
+                has_null: *has_null,
+                value: None,
+            }),
             _ => None,
         }
     }

src/query/functions-v2/src/scalars/boolean.rs

@@ -140,10 +140,11 @@ pub fn register(registry: &mut FunctionRegistry) {
             }
             None
         },
+        // value = lhs & rhs,  valid = (lhs_v & rhs_v) | (!lhs & lhs_v) | (!rhs & rhs_v))
         vectorize_2_arg::<NullableType<BooleanType>, NullableType<BooleanType>, NullableType<BooleanType>>(|lhs, rhs| {
             let lhs_v = lhs.is_some();
             let rhs_v = rhs.is_some();
-            let valid = (lhs_v & rhs_v) | (lhs == Some(true)) | (rhs == Some(true));
+            let valid = (lhs_v & rhs_v) | (lhs == Some(false)) | (rhs == Some(false));
             if valid {
                 Some(lhs.unwrap_or_default() & rhs.unwrap_or_default())
             } else {
@@ -171,8 +172,9 @@ pub fn register(registry: &mut FunctionRegistry) {
             }
             None
         },
+        // value = lhs | rhs,  valid = (lhs_v & rhs_v) | (lhs | rhs))
         vectorize_2_arg::<NullableType<BooleanType>, NullableType<BooleanType>, NullableType<BooleanType>>(|lhs, rhs| {
-            let valid = (lhs.is_some() & rhs.is_some()) | lhs.unwrap_or_default() | rhs.unwrap_or_default();
+            let valid = (lhs.is_some() & rhs.is_some()) | (lhs.unwrap_or_default() | rhs.unwrap_or_default());
             if valid {
                 Some(lhs.unwrap_or_default() | rhs.unwrap_or_default())
             } else {

src/query/functions-v2/tests/it/scalars/testdata/boolean.txt

@@ -10,10 +10,10 @@ output         : false
 ast            : true AND null
 raw expr       : and(true, NULL)
 checked expr   : and<Boolean NULL, Boolean NULL>(CAST(true AS Boolean NULL), CAST(NULL AS Boolean NULL))
-optimized expr : false
+optimized expr : NULL
 output type    : Boolean NULL
 output domain  : Unknown
-output         : false
+output         : NULL
 
 
 ast            : true AND true
@@ -37,10 +37,10 @@ output         : false
 ast            : false AND null
 raw expr       : and(false, NULL)
 checked expr   : and<Boolean NULL, Boolean NULL>(CAST(false AS Boolean NULL), CAST(NULL AS Boolean NULL))
-optimized expr : NULL
+optimized expr : false
 output type    : Boolean NULL
 output domain  : Unknown
-output         : NULL
+output         : false
 
 
 ast            : false AND true