fix(query): to_string(DateColumn, format) should success if date = 9999-12-31 (#18321)

Author: TCeason

src/query/expression/src/utils/date_helper.rs

@@ -836,20 +836,28 @@ pub fn calc_date_to_timestamp(val: i32, tz: TimeZone) -> std::result::Result<i64
     let ts = (val as i64) * 24 * 3600 * MICROS_PER_SEC;
     let z = ts.to_timestamp(tz.clone());
 
+    let tomorrow = z.date().tomorrow();
+    let yesterday = z.date().yesterday();
+
+    // If there were no yesterday or tomorrow, it might be the limit value.
+    // e.g. 9999-12-31
+    if tomorrow.is_err() || yesterday.is_err() {
+        let tz_offset_micros = tz
+            .to_timestamp(date(1970, 1, 1).at(0, 0, 0, 0))
+            .unwrap()
+            .as_microsecond();
+        return Ok(ts + tz_offset_micros);
+    }
+
     // tomorrow midnight
-    let tomorrow_date = z
-        .date()
-        .tomorrow()
-        .map_err(|e| format!("Calc tomorrow midnight with error {}", e))?;
+    let tomorrow_date = tomorrow.map_err(|e| format!("Calc tomorrow midnight with error {}", e))?;
 
     let tomorrow_zoned = tomorrow_date.to_zoned(tz.clone()).unwrap_or(z.clone());
     let tomorrow_is_dst = tz.to_offset_info(tomorrow_zoned.timestamp()).dst().is_dst();
 
     // yesterday midnight
-    let yesterday_date = z
-        .date()
-        .yesterday()
-        .map_err(|e| format!("Calc yesterday midnight with error {}", e))?;
+    let yesterday_date =
+        yesterday.map_err(|e| format!("Calc yesterday midnight with error {}", e))?;
     let yesterday_zoned = yesterday_date.to_zoned(tz.clone()).unwrap_or(z.clone());
     let yesterday_is_std = tz
         .to_offset_info(yesterday_zoned.timestamp())

src/query/functions/src/scalars/timestamp/src/datetime.rs

@@ -732,15 +732,10 @@ fn register_to_string(registry: &mut FunctionRegistry) {
         vectorize_with_builder_2_arg::<TimestampType, StringType, NullableType<StringType>>(
             |micros, format, output, ctx| {
                 let ts = micros.to_timestamp(ctx.func_ctx.tz.clone());
-                let format = if ctx.func_ctx.date_format_style == *"oracle" {
-                    pg_format_to_strftime(format)
-                } else {
-                    format.to_string()
-                };
-                let format = replace_time_format(&format);
+                let format = prepare_format_string(format, &ctx.func_ctx.date_format_style);
                 let mut buf = String::new();
                 let mut formatter = fmt::Formatter::new(&mut buf, FormattingOptions::new());
-                if Display::fmt(&ts.strftime(format.as_ref()), &mut formatter).is_err() {
+                if Display::fmt(&ts.strftime(&format), &mut formatter).is_err() {
                     ctx.set_error(output.len(), format!("{format} is invalid time format"));
                     output.builder.commit_row();
                     output.validity.push(true);
@@ -2453,3 +2448,12 @@ where T: ToNumber<i32> {
         }),
     );
 }
+
+fn prepare_format_string(format: &str, date_format_style: &str) -> String {
+    let processed_format = if date_format_style == "oracle" {
+        pg_format_to_strftime(format)
+    } else {
+        format.to_string()
+    };
+    replace_time_format(&processed_format).to_string()
+}

tests/sqllogictests/suites/query/functions/02_0012_function_datetimes_tz.test

@@ -1143,6 +1143,19 @@ select to_date('9999-12-31','%Y-%m-%d');
 ----
 9999-12-31
 
+statement ok
+create or replace table t(c1 date);
+
+statement ok
+insert into t values('9999-12-31');
+
+query T
+select to_string(c1, '%Y'),c1 from t;
+----
+9999 9999-12-31
+
+statement ok
+drop table if exists t;
 
 statement ok
 set timezone='America/Los_Angeles';