refacor source by comment

Author: lichuang

src/query/storages/index/benches/build_from_block.rs

@@ -44,7 +44,8 @@ fn bench_u64(c: &mut Criterion) {
     let column = block.try_column_by_name("a").unwrap();
 
     let mut builder = Xor8Builder::create();
-    let values: Vec<DataValue> = (0..column.len()).map(|i| column.get(i)).collect();
+    let mut values = vec![];
+    (0..column.len()).for_each(|i| values.push(column.get(i)));
     builder.add_keys(&values);
     let filter = builder.build().unwrap();
 
@@ -55,7 +56,6 @@ fn bench_u64(c: &mut Criterion) {
     c.bench_function("xor8_filter_u64_1m_rows_build_from_column_to_values", |b| {
         b.iter(|| {
             let mut builder = Xor8Builder::create();
-            let values: Vec<DataValue> = (0..column.len()).map(|i| column.get(i)).collect();
             builder.add_keys(&criterion::black_box(values));
             let _filter = criterion::black_box(builder.build().unwrap());
         })
@@ -67,7 +67,8 @@ fn bench_string(c: &mut Criterion) {
     let column = block.try_column_by_name("a").unwrap();
 
     let mut builder = Xor8Builder::create();
-    let values: Vec<DataValue> = (0..column.len()).map(|i| column.get(i)).collect();
+    let mut values = vec![];
+    (0..column.len()).for_each(|i| values.push(column.get(i)));
     builder.add_keys(&values);
     let filter = builder.build().unwrap();
 
@@ -80,7 +81,6 @@ fn bench_string(c: &mut Criterion) {
         |b| {
             b.iter(|| {
                 let mut builder = Xor8Builder::create();
-                let values: Vec<DataValue> = (0..column.len()).map(|i| column.get(i)).collect();
                 builder.add_keys(&criterion::black_box(values));
                 let _filter = criterion::black_box(builder.build().unwrap());
             })