Skip to content

Commit e7a191c

Browse files
committed
fix test fail
1 parent bb3a96c commit e7a191c

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/query/storages/index/benches/build_from_block.rs

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ fn bench_u64(c: &mut Criterion) {
4444
let column = block.try_column_by_name("a").unwrap();
4545

4646
let mut builder = Xor8Builder::create();
47-
let mut values = vec![];
48-
(0..column.len()).for_each(|i| values.push(column.get(i)));
49-
builder.add_keys(&values);
47+
(0..column.len()).for_each(|i| builder.add_key(&column.get(i)));
5048
let filter = builder.build().unwrap();
5149

5250
for key in &values {
@@ -55,10 +53,8 @@ fn bench_u64(c: &mut Criterion) {
5553

5654
c.bench_function("xor8_filter_u64_1m_rows_build_from_column_to_values", |b| {
5755
b.iter(|| {
58-
let mut values = vec![];
59-
(0..column.len()).for_each(|i| values.push(column.get(i)));
6056
let mut builder = Xor8Builder::create();
61-
builder.add_keys(&criterion::black_box(values));
57+
(0..column.len()).for_each(|i| builder.add_key(&column.get(i)));
6258
let _filter = criterion::black_box(builder.build().unwrap());
6359
})
6460
});
@@ -69,9 +65,7 @@ fn bench_string(c: &mut Criterion) {
6965
let column = block.try_column_by_name("a").unwrap();
7066

7167
let mut builder = Xor8Builder::create();
72-
let mut values = vec![];
73-
(0..column.len()).for_each(|i| values.push(column.get(i)));
74-
builder.add_keys(&values);
68+
(0..column.len()).for_each(|i| builder.add_key(&column.get(i)));
7569
let filter = builder.build().unwrap();
7670

7771
for key in values {
@@ -81,11 +75,9 @@ fn bench_string(c: &mut Criterion) {
8175
c.bench_function(
8276
"xor8_filter_string16to32_1m_rows_build_from_column_to_values",
8377
|b| {
84-
let mut values = vec![];
85-
(0..column.len()).for_each(|i| values.push(column.get(i)));
8678
b.iter(|| {
8779
let mut builder = Xor8Builder::create();
88-
builder.add_keys(&criterion::black_box(values));
80+
(0..column.len()).for_each(|i| builder.add_key(&column.get(i)));
8981
let _filter = criterion::black_box(builder.build().unwrap());
9082
})
9183
},

0 commit comments

Comments
 (0)