@@ -44,9 +44,7 @@ fn bench_u64(c: &mut Criterion) {
44
44
let column = block. try_column_by_name ( "a" ) . unwrap ( ) ;
45
45
46
46
let mut builder = Xor8Builder :: create ( ) ;
47
- let mut values = vec ! [ ] ;
48
- ( 0 ..column. len ( ) ) . for_each ( |i| values. push ( column. get ( i) ) ) ;
49
- builder. add_keys ( & values) ;
47
+ ( 0 ..column. len ( ) ) . for_each ( |i| builder. add_key ( & column. get ( i) ) ) ;
50
48
let filter = builder. build ( ) . unwrap ( ) ;
51
49
52
50
for key in & values {
@@ -55,10 +53,8 @@ fn bench_u64(c: &mut Criterion) {
55
53
56
54
c. bench_function ( "xor8_filter_u64_1m_rows_build_from_column_to_values" , |b| {
57
55
b. iter ( || {
58
- let mut values = vec ! [ ] ;
59
- ( 0 ..column. len ( ) ) . for_each ( |i| values. push ( column. get ( i) ) ) ;
60
56
let mut builder = Xor8Builder :: create ( ) ;
61
- builder. add_keys ( & criterion :: black_box ( values ) ) ;
57
+ ( 0 ..column . len ( ) ) . for_each ( |i| builder. add_key ( & column . get ( i ) ) ) ;
62
58
let _filter = criterion:: black_box ( builder. build ( ) . unwrap ( ) ) ;
63
59
} )
64
60
} ) ;
@@ -69,9 +65,7 @@ fn bench_string(c: &mut Criterion) {
69
65
let column = block. try_column_by_name ( "a" ) . unwrap ( ) ;
70
66
71
67
let mut builder = Xor8Builder :: create ( ) ;
72
- let mut values = vec ! [ ] ;
73
- ( 0 ..column. len ( ) ) . for_each ( |i| values. push ( column. get ( i) ) ) ;
74
- builder. add_keys ( & values) ;
68
+ ( 0 ..column. len ( ) ) . for_each ( |i| builder. add_key ( & column. get ( i) ) ) ;
75
69
let filter = builder. build ( ) . unwrap ( ) ;
76
70
77
71
for key in values {
@@ -81,11 +75,9 @@ fn bench_string(c: &mut Criterion) {
81
75
c. bench_function (
82
76
"xor8_filter_string16to32_1m_rows_build_from_column_to_values" ,
83
77
|b| {
84
- let mut values = vec ! [ ] ;
85
- ( 0 ..column. len ( ) ) . for_each ( |i| values. push ( column. get ( i) ) ) ;
86
78
b. iter ( || {
87
79
let mut builder = Xor8Builder :: create ( ) ;
88
- builder. add_keys ( & criterion :: black_box ( values ) ) ;
80
+ ( 0 ..column . len ( ) ) . for_each ( |i| builder. add_key ( & column . get ( i ) ) ) ;
89
81
let _filter = criterion:: black_box ( builder. build ( ) . unwrap ( ) ) ;
90
82
} )
91
83
} ,
0 commit comments