Skip to content

Commit dceca56

Browse files
committed
1. fix
2. add tasks and task_history to SYSTEM_TABLES_ALLOW_LIST 3. delete useless test
1 parent 348da41 commit dceca56

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

src/query/ast/src/parser/statement.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2861,7 +2861,7 @@ pub fn priv_type(i: Input) -> IResult<UserPrivilegeType> {
28612861
UserPrivilegeType::CreateDatabase,
28622862
rule! { CREATE ~ DATABASE },
28632863
),
2864-
value(UserPrivilegeType::CreateDatabase, rule! { CREATE ~ TASK }),
2864+
value(UserPrivilegeType::CreateTask, rule! { CREATE ~ TASK }),
28652865
value(UserPrivilegeType::DropUser, rule! { DROP ~ USER }),
28662866
value(UserPrivilegeType::CreateRole, rule! { CREATE ~ ROLE }),
28672867
value(UserPrivilegeType::DropRole, rule! { DROP ~ ROLE }),

src/query/service/src/interpreters/access/privilege_access.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ enum ObjectId {
5454
// some statements like `SELECT 1`, `SHOW USERS`, `SHOW ROLES`, `SHOW TABLES` will be
5555
// rewritten to the queries on the system tables, we need to skip the privilege check on
5656
// these tables.
57-
const SYSTEM_TABLES_ALLOW_LIST: [&str; 18] = [
57+
const SYSTEM_TABLES_ALLOW_LIST: [&str; 20] = [
5858
"catalogs",
5959
"columns",
6060
"databases",
@@ -73,6 +73,8 @@ const SYSTEM_TABLES_ALLOW_LIST: [&str; 18] = [
7373
"processes",
7474
"user_functions",
7575
"functions",
76+
"tasks",
77+
"task_history",
7678
];
7779

7880
impl PrivilegeAccess {

tests/suites/0_stateless/18_rbac/18_0011_task.result

Whitespace-only changes.

tests/suites/0_stateless/18_rbac/18_0011_task.sh

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)