Skip to content

Commit b2e9608

Browse files
committed
fix(query): fix deserialize bug for aggregation
1 parent 7c3cd50 commit b2e9608

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

src/query/functions-v2/src/aggregates/adaptors/aggregate_null_unary_adaptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,9 @@ impl<const NULLABLE_RESULT: bool> AggregateFunction for AggregateNullUnaryAdapto
182182

183183
fn deserialize(&self, place: StateAddr, reader: &mut &[u8]) -> Result<()> {
184184
if NULLABLE_RESULT {
185+
let flag = reader[reader.len() - 1];
185186
self.nested
186187
.deserialize(place, &mut &reader[..reader.len() - 1])?;
187-
let flag = reader[reader.len() - 1];
188188
self.set_flag(place, flag);
189189
} else {
190190
self.nested.deserialize(place, reader)?;

src/query/functions-v2/src/aggregates/adaptors/aggregate_null_variadic_adaptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,9 @@ impl<const NULLABLE_RESULT: bool> AggregateFunction
184184

185185
fn deserialize(&self, place: StateAddr, reader: &mut &[u8]) -> Result<()> {
186186
if NULLABLE_RESULT {
187+
let flag = reader[reader.len() - 1];
187188
self.nested
188189
.deserialize(place, &mut &reader[..reader.len() - 1])?;
189-
let flag = reader[reader.len() - 1];
190190
self.set_flag(place, flag);
191191
} else {
192192
self.nested.deserialize(place, reader)?;

src/query/functions-v2/src/aggregates/adaptors/aggregate_ornull_adaptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,9 @@ impl AggregateFunction for AggregateFunctionOrNullAdaptor {
174174

175175
#[inline]
176176
fn deserialize(&self, place: StateAddr, reader: &mut &[u8]) -> Result<()> {
177+
let flag = reader[reader.len() - 1];
177178
self.inner
178179
.deserialize(place, &mut &reader[..reader.len() - 1])?;
179-
let flag = reader[reader.len() - 1];
180180
self.set_flag(place, flag);
181181
Ok(())
182182
}

src/query/functions/src/aggregates/adaptors/aggregate_null_unary_adaptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,9 @@ impl<const NULLABLE_RESULT: bool> AggregateFunction for AggregateNullUnaryAdapto
183183

184184
fn deserialize(&self, place: StateAddr, reader: &mut &[u8]) -> Result<()> {
185185
if NULLABLE_RESULT {
186+
let flag = reader[reader.len() - 1];
186187
self.nested
187188
.deserialize(place, &mut &reader[..reader.len() - 1])?;
188-
let flag = reader[reader.len() - 1];
189189
self.set_flag(place, flag);
190190
} else {
191191
self.nested.deserialize(place, reader)?;

src/query/functions/src/aggregates/adaptors/aggregate_null_variadic_adaptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,9 @@ impl<const NULLABLE_RESULT: bool> AggregateFunction
198198

199199
fn deserialize(&self, place: StateAddr, reader: &mut &[u8]) -> Result<()> {
200200
if NULLABLE_RESULT {
201+
let flag = reader[reader.len() - 1];
201202
self.nested
202203
.deserialize(place, &mut &reader[..reader.len() - 1])?;
203-
let flag = reader[reader.len() - 1];
204204
self.set_flag(place, flag);
205205
} else {
206206
self.nested.deserialize(place, reader)?;

src/query/functions/src/aggregates/adaptors/aggregate_ornull_adaptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,9 @@ impl AggregateFunction for AggregateFunctionOrNullAdaptor {
178178

179179
#[inline]
180180
fn deserialize(&self, place: StateAddr, reader: &mut &[u8]) -> Result<()> {
181+
let flag = reader[reader.len() - 1];
181182
self.inner
182183
.deserialize(place, &mut &reader[..reader.len() - 1])?;
183-
let flag = reader[reader.len() - 1];
184184
self.set_flag(place, flag);
185185
Ok(())
186186
}

0 commit comments

Comments
 (0)