improve with reviewers suggestion

Author: ariesdevil

src/query/service/src/servers/http/v1/load.rs

@@ -195,10 +195,10 @@ pub async fn streaming_load(
                 let input_context = Arc::new(
                     InputContext::try_create_from_insert_v2(
                         rx,
-                        ctx.get_settings(),
+                        context.get_settings(),
                         option_settings.clone(),
                         schema,
-                        ctx.get_scan_progress(),
+                        context.get_scan_progress(),
                         false,
                         to_table.get_block_compact_thresholds(),
                     )

src/query/settings/src/lib.rs

@@ -27,7 +27,6 @@ use common_base::runtime::TrySpawn;
 use common_config::Config;
 use common_exception::ErrorCode;
 use common_exception::Result;
-use common_meta_types::FileFormatOptions;
 use common_meta_types::UserSetting;
 use common_meta_types::UserSettingValue;
 use common_users::UserApiProvider;
@@ -492,38 +491,6 @@ impl Settings {
         }))
     }
 
-    pub fn set_file_format_options(&self, opts: &FileFormatOptions) -> Result<()> {
-        // hack here for associate args in streaming load with file_format_option in copy into.
-        // format_skip_header -> skip_header
-        // format_compression -> compression
-        // format_field_delimiter -> field_delimiter
-        // format_record_delimiter -> record_delimiter
-        // format_quote -> escape
-        self.set_settings(
-            "format_skip_header".to_string(),
-            opts.skip_header.to_string(),
-            false,
-        )?;
-        self.set_settings(
-            "format_compression".to_string(),
-            opts.compression.to_string(),
-            false,
-        )?;
-        self.set_settings(
-            "format_field_delimiter".to_string(),
-            opts.field_delimiter.clone(),
-            false,
-        )?;
-        self.set_settings(
-            "format_record_delimiter".to_string(),
-            opts.record_delimiter.clone(),
-            false,
-        )?;
-        self.set_settings("format_quote".to_string(), opts.escape.clone(), false)?;
-
-        Ok(())
-    }
-
     // Get max_block_size.
     pub fn get_max_block_size(&self) -> Result<u64> {
         let key = "max_block_size";