refactor: remove databend-common-base from databend-common-ast (#15519)

Author: andylokandy

src/query/ast/Cargo.toml

@@ -16,7 +16,6 @@ ignored = ["geos"]
 
 [dependencies] # In alphabetical order
 # Workspace dependencies
-databend-common-base = { path = "../../common/base" }
 databend-common-exception = { path = "../../common/exception" }
 databend-common-io = { path = "../../common/io" }
 

src/query/ast/src/ast/statements/copy.rs

@@ -20,7 +20,6 @@ use std::io::Error;
 use std::io::ErrorKind;
 use std::io::Result;
 
-use databend_common_base::base::mask_string;
 use databend_common_exception::ErrorCode;
 use databend_common_io::escape_string_with_quote;
 use derive_visitor::Drive;
@@ -314,6 +313,17 @@ impl Display for Connection {
     }
 }
 
+/// Mask a string by "******", but keep `unmask_len` of suffix.
+fn mask_string(s: &str, unmask_len: usize) -> String {
+    if s.len() <= unmask_len {
+        s.to_string()
+    } else {
+        let mut ret = "******".to_string();
+        ret.push_str(&s[(s.len() - unmask_len)..]);
+        ret
+    }
+}
+
 /// UriLocation (a.k.a external location) can be used in `INTO` or `FROM`.
 ///
 /// For examples: `'s3://example/path/to/dir' CONNECTION = (AWS_ACCESS_ID="admin" AWS_SECRET_KEY="admin")`
@@ -400,16 +410,19 @@ impl UriLocation {
             connection: Connection::new(conns),
         })
     }
+
+    pub fn mask(&self) -> Self {
+        Self {
+            connection: self.connection.mask(),
+            ..self.clone()
+        }
+    }
 }
 
 impl Display for UriLocation {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         write!(f, "'{}://{}{}'", self.protocol, self.name, self.path)?;
-        if f.alternate() {
-            write!(f, "{}", self.connection.mask())?;
-        } else {
-            write!(f, "{}", self.connection)?;
-        }
+        write!(f, "{}", self.connection)?;
         if !self.part_prefix.is_empty() {
             write!(f, " LOCATION_PREFIX = '{}'", self.part_prefix)?;
         }

src/query/sql/src/planner/binder/ddl/table.rs

@@ -697,7 +697,7 @@ impl Binder {
         // keep a copy of table data uri_location, will be used in "show create table"
         options.insert(
             OPT_KEY_TABLE_ATTACHED_DATA_URI.to_string(),
-            format!("{:#}", stmt.uri_location),
+            format!("{}", stmt.uri_location.mask()),
         );
 
         let mut uri = stmt.uri_location.clone();

src/query/sql/src/planner/semantic/type_check.rs

@@ -3537,7 +3537,7 @@ impl<'a> TypeChecker<'a> {
                 .await
                 .map_err(|err| {
                     ErrorCode::SemanticError(format!(
-                        "Failed to resolve WASM code location {:#?}: {}",
+                        "Failed to resolve WASM code location {:?}: {}",
                         &udf_definition.code, err
                     ))
                 })?;