wip

Author: dantengsky

src/query/storages/common/blocks/src/block.rs

@@ -90,16 +90,21 @@ pub fn blocks_to_parquet(
     }
 }
 
-fn col_encoding(_data_type: &ArrowDataType) -> Encoding {
-    // Although encoding does work, parquet2 has not implemented decoding of DeltaLengthByteArray yet, we fallback to Plain
-    // From parquet2: Decoding "DeltaLengthByteArray"-encoded required V2 pages is not yet implemented for Binary.
+fn col_encoding(data_type: &ArrowDataType) -> Encoding {
     //
-    // match data_type {
-    //    ArrowDataType::Binary
-    //    | ArrowDataType::LargeBinary
-    //    | ArrowDataType::Utf8
-    //    | ArrowDataType::LargeUtf8 => Encoding::DeltaLengthByteArray,
-    //    _ => Encoding::Plain,
-    //}
-    Encoding::Plain
+    match data_type {
+        ArrowDataType::Int8
+        | ArrowDataType::Int16
+        | ArrowDataType::Int32
+        | ArrowDataType::Int64
+        | ArrowDataType::UInt8
+        | ArrowDataType::UInt16
+        | ArrowDataType::UInt32
+        | ArrowDataType::UInt64 => Encoding::DeltaBinaryPacked,
+        ArrowDataType::Float16 | ArrowDataType::Float32 => Encoding::ByteStreamSplit,
+        //  | ArrowDataType::LargeBinary
+        //  | ArrowDataType::Utf8
+        //  | ArrowDataType::LargeUtf8 => Encoding::DeltaLengthByteArray,
+        _ => Encoding::Plain,
+    }
 }