Merge pull request #7686 from b41sh/fix-cast-deterministic

mergify[bot] · web-flow · commit 9ea070efc8c9 · 2022-09-18T07:45:31.000Z
fix(query): fix cast deterministic error
diff --git a/src/query/service/src/sql/planner/plans/scalar.rs b/src/query/service/src/sql/planner/plans/scalar.rs
@@ -511,7 +511,7 @@ impl ScalarExpr for CastExpr {
     }
 
     fn is_deterministic(&self) -> bool {
-        true
+        self.argument.is_deterministic()
     }
 }
 
diff --git a/tests/logictest/suites/base/02_function/02_0002_function_cast b/tests/logictest/suites/base/02_function/02_0002_function_cast
@@ -524,3 +524,10 @@ SELECT parse_json('[1,2,3]')::object;
 statement error 1010
 SELECT parse_json('null')::object;
 
+
+statement query I
+SELECT count(distinct a) FROM (SELECT rand()::string AS a FROM numbers(10));
+
+----
+10
+

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,7 @@ impl ScalarExpr for CastExpr {`
`511`	`511`	`}`
`512`	`512`
`513`	`513`	`fn is_deterministic(&self) -> bool {`
`514`		`- true`
	`514`	`+ self.argument.is_deterministic()`
`515`	`515`	`}`
`516`	`516`	`}`
`517`	`517`