refactor: remove innecessary serde (#15042)

drmingdrmer · web-flow · commit 89cdf6bf323e · 2024-03-20T17:11:10.000+08:00
diff --git a/src/meta/app/src/background/background_job.rs b/src/meta/app/src/background/background_job.rs
@@ -24,16 +24,7 @@ use cron::Schedule;
 use crate::background::BackgroundTaskType;
 use crate::principal::UserIdentity;
 
-#[derive(
-    serde::Serialize,
-    serde::Deserialize,
-    Clone,
-    Debug,
-    Default,
-    Eq,
-    PartialEq,
-    num_derive::FromPrimitive,
-)]
+#[derive(Clone, Debug, Default, Eq, PartialEq, num_derive::FromPrimitive)]
 pub enum BackgroundJobState {
     #[default]
     RUNNING = 0,
@@ -47,16 +38,7 @@ impl Display for BackgroundJobState {
     }
 }
 
-#[derive(
-    serde::Serialize,
-    serde::Deserialize,
-    Clone,
-    Debug,
-    Default,
-    Eq,
-    PartialEq,
-    num_derive::FromPrimitive,
-)]
+#[derive(Clone, Debug, Default, Eq, PartialEq, num_derive::FromPrimitive)]
 pub enum BackgroundJobType {
     #[default]
     ONESHOT = 0,
@@ -87,7 +69,7 @@ impl ManualTriggerParams {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct BackgroundJobParams {
     pub job_type: BackgroundJobType,
     pub scheduled_job_interval: std::time::Duration,
@@ -159,7 +141,7 @@ impl Display for BackgroundJobParams {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct BackgroundJobStatus {
     pub job_state: BackgroundJobState,
     pub last_task_id: Option<String>,
@@ -216,7 +198,7 @@ impl Display for BackgroundJobIdent {
 }
 
 // Info
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct BackgroundJobInfo {
     pub job_params: Option<BackgroundJobParams>,
     pub job_status: Option<BackgroundJobStatus>,
@@ -244,12 +226,12 @@ impl BackgroundJobInfo {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct BackgroundJobId {
     pub id: u64,
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct CreateBackgroundJobReq {
     pub if_not_exists: bool,
     pub job_name: BackgroundJobIdent,
@@ -271,12 +253,12 @@ impl Display for CreateBackgroundJobReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct CreateBackgroundJobReply {
     pub id: u64,
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct GetBackgroundJobReq {
     pub name: BackgroundJobIdent,
 }
@@ -287,13 +269,13 @@ impl Display for GetBackgroundJobReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct GetBackgroundJobReply {
     pub id: u64,
     pub info: BackgroundJobInfo,
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct UpdateBackgroundJobStatusReq {
     pub job_name: BackgroundJobIdent,
     pub status: BackgroundJobStatus,
@@ -309,7 +291,7 @@ impl Display for UpdateBackgroundJobStatusReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct UpdateBackgroundJobParamsReq {
     pub job_name: BackgroundJobIdent,
     pub params: BackgroundJobParams,
@@ -325,7 +307,7 @@ impl Display for UpdateBackgroundJobParamsReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct UpdateBackgroundJobReq {
     pub job_name: BackgroundJobIdent,
     pub info: BackgroundJobInfo,
@@ -347,12 +329,12 @@ impl Display for UpdateBackgroundJobReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct UpdateBackgroundJobReply {
     pub id: u64,
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct DeleteBackgroundJobReq {
     pub name: BackgroundJobIdent,
 }
@@ -363,10 +345,10 @@ impl Display for DeleteBackgroundJobReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct DeleteBackgroundJobReply {}
 // list
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct ListBackgroundJobsReq {
     pub tenant: String,
 }
diff --git a/src/meta/app/src/background/background_task.rs b/src/meta/app/src/background/background_task.rs
@@ -70,7 +70,7 @@ impl Display for BackgroundTaskType {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct BackgroundTaskIdent {
     pub tenant: String,
     pub task_id: String,
@@ -153,7 +153,7 @@ impl BackgroundTaskInfo {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct UpdateBackgroundTaskReq {
     pub task_name: BackgroundTaskIdent,
     pub task_info: BackgroundTaskInfo,
@@ -174,13 +174,13 @@ impl Display for UpdateBackgroundTaskReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct UpdateBackgroundTaskReply {
     pub last_updated: DateTime<Utc>,
     pub expire_at: u64,
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct GetBackgroundTaskReq {
     pub name: BackgroundTaskIdent,
 }
@@ -191,12 +191,12 @@ impl Display for GetBackgroundTaskReq {
     }
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct GetBackgroundTaskReply {
     pub task_info: Option<BackgroundTaskInfo>,
 }
 
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct ListBackgroundTasksReq {
     pub tenant: String,
 }
diff --git a/src/query/config/src/background_config.rs b/src/query/config/src/background_config.rs
@@ -102,13 +102,13 @@ impl BackgroundScheduledConfig {
 }
 
 /// Config for background config
-#[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, PartialEq, Eq)]
 pub struct InnerBackgroundConfig {
     pub enable: bool,
     pub compaction: InnerBackgroundCompactionConfig,
 }
 
-#[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Clone, PartialEq, Eq)]
 pub struct InnerBackgroundCompactionConfig {
     pub enable: bool,
     pub target_tables: Option<Vec<String>>,

Original file line number	Diff line number	Diff line change
`@@ -24,16 +24,7 @@ use cron::Schedule;`
`24`	`24`	`use crate::background::BackgroundTaskType;`
`25`	`25`	`use crate::principal::UserIdentity;`
`26`	`26`
`27`		`-#[derive(`
`28`		`- serde::Serialize,`
`29`		`- serde::Deserialize,`
`30`		`- Clone,`
`31`		`- Debug,`
`32`		`- Default,`
`33`		`- Eq,`
`34`		`- PartialEq,`
`35`		`- num_derive::FromPrimitive,`
`36`		`-)]`
	`27`	`+#[derive(Clone, Debug, Default, Eq, PartialEq, num_derive::FromPrimitive)]`
`37`	`28`	`pub enum BackgroundJobState {`
`38`	`29`	`#[default]`
`39`	`30`	`RUNNING = 0,`
`@@ -47,16 +38,7 @@ impl Display for BackgroundJobState {`
`47`	`38`	`}`
`48`	`39`	`}`
`49`	`40`
`50`		`-#[derive(`
`51`		`- serde::Serialize,`
`52`		`- serde::Deserialize,`
`53`		`- Clone,`
`54`		`- Debug,`
`55`		`- Default,`
`56`		`- Eq,`
`57`		`- PartialEq,`
`58`		`- num_derive::FromPrimitive,`
`59`		`-)]`
	`41`	`+#[derive(Clone, Debug, Default, Eq, PartialEq, num_derive::FromPrimitive)]`
`60`	`42`	`pub enum BackgroundJobType {`
`61`	`43`	`#[default]`
`62`	`44`	`ONESHOT = 0,`
`@@ -87,7 +69,7 @@ impl ManualTriggerParams {`
`87`	`69`	`}`
`88`	`70`	`}`
`89`	`71`
`90`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]`
	`72`	`+#[derive(Clone, Debug, Default, Eq, PartialEq)]`
`91`	`73`	`pub struct BackgroundJobParams {`
`92`	`74`	`pub job_type: BackgroundJobType,`
`93`	`75`	`pub scheduled_job_interval: std::time::Duration,`
`@@ -159,7 +141,7 @@ impl Display for BackgroundJobParams {`
`159`	`141`	`}`
`160`	`142`	`}`
`161`	`143`
`162`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]`
	`144`	`+#[derive(Clone, Debug, Default, Eq, PartialEq)]`
`163`	`145`	`pub struct BackgroundJobStatus {`
`164`	`146`	`pub job_state: BackgroundJobState,`
`165`	`147`	`pub last_task_id: Option<String>,`
`@@ -216,7 +198,7 @@ impl Display for BackgroundJobIdent {`
`216`	`198`	`}`
`217`	`199`
`218`	`200`	`// Info`
`219`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]`
	`201`	`+#[derive(Clone, Debug, Default, Eq, PartialEq)]`
`220`	`202`	`pub struct BackgroundJobInfo {`
`221`	`203`	`pub job_params: Option<BackgroundJobParams>,`
`222`	`204`	`pub job_status: Option<BackgroundJobStatus>,`
`@@ -244,12 +226,12 @@ impl BackgroundJobInfo {`
`244`	`226`	`}`
`245`	`227`	`}`
`246`	`228`
`247`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]`
	`229`	`+#[derive(Clone, Debug, Default, Eq, PartialEq)]`
`248`	`230`	`pub struct BackgroundJobId {`
`249`	`231`	`pub id: u64,`
`250`	`232`	`}`
`251`	`233`
`252`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`234`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`253`	`235`	`pub struct CreateBackgroundJobReq {`
`254`	`236`	`pub if_not_exists: bool,`
`255`	`237`	`pub job_name: BackgroundJobIdent,`
`@@ -271,12 +253,12 @@ impl Display for CreateBackgroundJobReq {`
`271`	`253`	`}`
`272`	`254`	`}`
`273`	`255`
`274`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`256`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`275`	`257`	`pub struct CreateBackgroundJobReply {`
`276`	`258`	`pub id: u64,`
`277`	`259`	`}`
`278`	`260`
`279`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`261`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`280`	`262`	`pub struct GetBackgroundJobReq {`
`281`	`263`	`pub name: BackgroundJobIdent,`
`282`	`264`	`}`
`@@ -287,13 +269,13 @@ impl Display for GetBackgroundJobReq {`
`287`	`269`	`}`
`288`	`270`	`}`
`289`	`271`
`290`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`272`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`291`	`273`	`pub struct GetBackgroundJobReply {`
`292`	`274`	`pub id: u64,`
`293`	`275`	`pub info: BackgroundJobInfo,`
`294`	`276`	`}`
`295`	`277`
`296`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`278`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`297`	`279`	`pub struct UpdateBackgroundJobStatusReq {`
`298`	`280`	`pub job_name: BackgroundJobIdent,`
`299`	`281`	`pub status: BackgroundJobStatus,`
`@@ -309,7 +291,7 @@ impl Display for UpdateBackgroundJobStatusReq {`
`309`	`291`	`}`
`310`	`292`	`}`
`311`	`293`
`312`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`294`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`313`	`295`	`pub struct UpdateBackgroundJobParamsReq {`
`314`	`296`	`pub job_name: BackgroundJobIdent,`
`315`	`297`	`pub params: BackgroundJobParams,`
`@@ -325,7 +307,7 @@ impl Display for UpdateBackgroundJobParamsReq {`
`325`	`307`	`}`
`326`	`308`	`}`
`327`	`309`
`328`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`310`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`329`	`311`	`pub struct UpdateBackgroundJobReq {`
`330`	`312`	`pub job_name: BackgroundJobIdent,`
`331`	`313`	`pub info: BackgroundJobInfo,`
`@@ -347,12 +329,12 @@ impl Display for UpdateBackgroundJobReq {`
`347`	`329`	`}`
`348`	`330`	`}`
`349`	`331`
`350`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`332`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`351`	`333`	`pub struct UpdateBackgroundJobReply {`
`352`	`334`	`pub id: u64,`
`353`	`335`	`}`
`354`	`336`
`355`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`337`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`356`	`338`	`pub struct DeleteBackgroundJobReq {`
`357`	`339`	`pub name: BackgroundJobIdent,`
`358`	`340`	`}`
`@@ -363,10 +345,10 @@ impl Display for DeleteBackgroundJobReq {`
`363`	`345`	`}`
`364`	`346`	`}`
`365`	`347`
`366`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`348`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`367`	`349`	`pub struct DeleteBackgroundJobReply {}`
`368`	`350`	`// list`
`369`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`351`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`370`	`352`	`pub struct ListBackgroundJobsReq {`
`371`	`353`	`pub tenant: String,`
`372`	`354`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ impl Display for BackgroundTaskType {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
`73`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Default, Eq, PartialEq)]`
	`73`	`+#[derive(Clone, Debug, Default, Eq, PartialEq)]`
`74`	`74`	`pub struct BackgroundTaskIdent {`
`75`	`75`	`pub tenant: String,`
`76`	`76`	`pub task_id: String,`
`@@ -153,7 +153,7 @@ impl BackgroundTaskInfo {`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`
`156`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`156`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`157`	`157`	`pub struct UpdateBackgroundTaskReq {`
`158`	`158`	`pub task_name: BackgroundTaskIdent,`
`159`	`159`	`pub task_info: BackgroundTaskInfo,`
`@@ -174,13 +174,13 @@ impl Display for UpdateBackgroundTaskReq {`
`174`	`174`	`}`
`175`	`175`	`}`
`176`	`176`
`177`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`177`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`178`	`178`	`pub struct UpdateBackgroundTaskReply {`
`179`	`179`	`pub last_updated: DateTime<Utc>,`
`180`	`180`	`pub expire_at: u64,`
`181`	`181`	`}`
`182`	`182`
`183`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`183`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`184`	`184`	`pub struct GetBackgroundTaskReq {`
`185`	`185`	`pub name: BackgroundTaskIdent,`
`186`	`186`	`}`
`@@ -191,12 +191,12 @@ impl Display for GetBackgroundTaskReq {`
`191`	`191`	`}`
`192`	`192`	`}`
`193`	`193`
`194`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`194`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`195`	`195`	`pub struct GetBackgroundTaskReply {`
`196`	`196`	`pub task_info: Option<BackgroundTaskInfo>,`
`197`	`197`	`}`
`198`	`198`
`199`		`-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, PartialEq, Eq)]`
	`199`	`+#[derive(Clone, Debug, PartialEq, Eq)]`
`200`	`200`	`pub struct ListBackgroundTasksReq {`
`201`	`201`	`pub tenant: String,`
`202`	`202`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,13 +102,13 @@ impl BackgroundScheduledConfig {`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`/// Config for background config`
`105`		`-#[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]`
	`105`	`+#[derive(Clone, PartialEq, Eq)]`
`106`	`106`	`pub struct InnerBackgroundConfig {`
`107`	`107`	`pub enable: bool,`
`108`	`108`	`pub compaction: InnerBackgroundCompactionConfig,`
`109`	`109`	`}`
`110`	`110`
`111`		`-#[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]`
	`111`	`+#[derive(Clone, PartialEq, Eq)]`
`112`	`112`	`pub struct InnerBackgroundCompactionConfig {`
`113`	`113`	`pub enable: bool,`
`114`	`114`	`pub target_tables: Option<Vec<String>>,`