add comment

Author: andylokandy

src/query/codegen/Cargo.toml

@@ -18,6 +18,8 @@ path = "src/bin/codegen.rs"
 common-datavalues = { path = "../datavalues" }
 common-expression = { path = "../expression" }
 
+# TODO(andylokandy): Use the version from crates.io once
+# https://github.com/reem/rust-ordered-float/pull/110 is released.
 ordered-float = { git = "https://github.com/andylokandy/rust-ordered-float.git", branch = "as", features = ["serde"] }
 serde = { version = "1.0.137", features = ["derive"] }
 serde_json = "1.0.81"

src/query/expression/Cargo.toml

@@ -25,6 +25,8 @@ enum-as-inner = "0.4"
 itertools = "0.10"
 match-template = "0.0.1"
 num-traits = "0.2.15"
+# TODO(andylokandy): Use the version from crates.io once
+# https://github.com/reem/rust-ordered-float/pull/110 is released.
 ordered-float = { git = "https://github.com/andylokandy/rust-ordered-float.git", branch = "as", features = ["serde"] }
 serde = "1.0"
 

src/query/expression/src/column_from.rs

@@ -124,7 +124,7 @@ impl<'a, D: AsRef<[&'a str]>> ColumnFrom<D, [Vec<u8>; 2]> for Column {
     }
 }
 
-impl<'a, D: AsRef<[f32]>> ColumnFrom<D, [Vec<f32>; 0]> for Column {
+impl<D: AsRef<[f32]>> ColumnFrom<D, [Vec<f32>; 0]> for Column {
     fn from_data(d: D) -> Column {
         NumberType::<OrderedFloat<f32>>::upcast_column(
             NumberType::<OrderedFloat<f32>>::column_from_iter(
@@ -135,7 +135,7 @@ impl<'a, D: AsRef<[f32]>> ColumnFrom<D, [Vec<f32>; 0]> for Column {
     }
 }
 
-impl<'a, D: AsRef<[f64]>> ColumnFrom<D, [Vec<f64>; 0]> for Column {
+impl<D: AsRef<[f64]>> ColumnFrom<D, [Vec<f64>; 0]> for Column {
     fn from_data(d: D) -> Column {
         NumberType::<OrderedFloat<f64>>::upcast_column(
             NumberType::<OrderedFloat<f64>>::column_from_iter(

src/query/functions-v2/Cargo.toml

@@ -23,6 +23,8 @@ hex = "0.4.3"
 itertools = "0.10.3"
 match-template = "0.0.1"
 num-traits = "0.2.15"
+# TODO(andylokandy): Use the version from crates.io once
+# https://github.com/reem/rust-ordered-float/pull/110 is released.
 ordered-float = { git = "https://github.com/andylokandy/rust-ordered-float.git", branch = "as", features = [
     "serde",
     "rand",