Skip to content

Commit 635e598

Browse files
committed
refactor(meta): remove back compatability supporting code
1 parent 0ec6195 commit 635e598

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

src/meta/client/src/grpc_client.rs

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -715,21 +715,22 @@ impl MetaGrpcClient {
715715
let resp =
716716
res.map_err(|status| MetaHandshakeError::new("handshake is refused", &status))?;
717717

718-
// backward compatibility: no version in handshake.
719-
// TODO(xp): remove this when merged.
720-
if resp.protocol_version > 0 {
721-
let min_compatible = to_digit_ver(min_metasrv_ver);
722-
if resp.protocol_version < min_compatible {
723-
let invalid_err = AnyError::error(format!(
724-
"metasrv protocol_version({}) < meta-client min-compatible({})",
725-
from_digit_ver(resp.protocol_version),
726-
min_metasrv_ver,
727-
));
728-
return Err(MetaHandshakeError::new(
729-
"incompatible protocol version",
730-
&invalid_err,
731-
));
732-
}
718+
assert!(
719+
resp.protocol_version > 0,
720+
"talking to a very old databend-meta: upgrade databend-meta to at least 0.8"
721+
);
722+
723+
let min_compatible = to_digit_ver(min_metasrv_ver);
724+
if resp.protocol_version < min_compatible {
725+
let invalid_err = AnyError::error(format!(
726+
"metasrv protocol_version({}) < meta-client min-compatible({})",
727+
from_digit_ver(resp.protocol_version),
728+
min_metasrv_ver,
729+
));
730+
return Err(MetaHandshakeError::new(
731+
"incompatible protocol version",
732+
&invalid_err,
733+
));
733734
}
734735

735736
let token = resp.payload;

0 commit comments

Comments
 (0)