Skip to content

Commit 5d99fc9

Browse files
committed
Fix some tests with async
1 parent c355ab9 commit 5d99fc9

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/query/service/src/interpreters/access/management_mode_access.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ impl ManagementModeAccess {
3333
}
3434
}
3535

36+
#[async_trait::async_trait]
3637
impl AccessChecker for ManagementModeAccess {
3738
// Check what we can do if in management mode.
3839
fn check(&self, plan: &PlanNode) -> Result<()> {
@@ -50,7 +51,7 @@ impl AccessChecker for ManagementModeAccess {
5051
}
5152

5253
// Check what we can do if in management mode.
53-
fn check_new(&self, plan: &Plan) -> Result<()> {
54+
async fn check_new(&self, plan: &Plan) -> Result<()> {
5455
// Allows for management-mode.
5556
if self.ctx.get_config().query.management_mode {
5657
let ok = match plan {

src/query/service/tests/it/interpreters/interpreter_setting.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ async fn test_setting_interpreter_error() -> Result<()> {
4242

4343
let query = "SET max_block_size=1";
4444
let (plan, _, _) = planner.plan_sql(query).await?;
45-
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan)?;
45+
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan).await?;
4646
if let Err(e) = executor.execute(ctx.clone()).await {
4747
let expect = "Code: 1020, displayText = Unknown variable: \"xx\".";
4848
assert_eq!(expect, e.to_string());

src/query/service/tests/it/interpreters/interpreter_table_show_create.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,11 @@ async fn interpreter_show_create_table_with_comments_test() -> Result<()> {
156156
for stmt in case.create_stmt {
157157
// create table in the new planner to support column comment.
158158
let (plan, _, _) = planner.plan_sql(stmt).await?;
159-
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan)?;
159+
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan).await?;
160160
let _ = executor.execute(ctx.clone()).await?;
161161
}
162162
let (plan, _, _) = planner.plan_sql(case.show_stmt).await?;
163-
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan)?;
163+
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan).await?;
164164
assert_eq!(executor.name(), "ShowCreateTableInterpreter");
165165
let result = executor
166166
.execute(ctx.clone())

src/query/service/tests/it/interpreters/interpreter_use_database.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ async fn test_use_interpreter() -> Result<()> {
2626

2727
let query = "USE default";
2828
let (plan, _, _) = planner.plan_sql(query).await?;
29-
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan)?;
29+
let executor = InterpreterFactoryV2::get(ctx.clone(), &plan).await?;
3030
assert_eq!(executor.name(), "UseDatabaseInterpreter");
3131

3232
let mut stream = executor.execute(ctx.clone()).await?;

0 commit comments

Comments
 (0)