fix(meta/test): in a testing function, return a fake error when trying to get abasent key

Author: drmingdrmer

src/meta/api/src/kv_api_utils.rs

@@ -20,6 +20,7 @@ use common_meta_app::schema::DatabaseMeta;
 use common_meta_app::schema::DatabaseNameIdent;
 use common_meta_app::schema::TableNameIdent;
 use common_meta_app::share::*;
+use common_meta_types::anyerror::AnyError;
 use common_meta_types::app_error::AppError;
 use common_meta_types::app_error::ShareHasNoGrantedDatabase;
 use common_meta_types::app_error::UnknownDatabase;
@@ -486,6 +487,7 @@ where
 }
 
 /// Get existing value by key. Panic if key is absent.
+/// This function is only used for testing.
 pub async fn get_kv_data<T>(
     kv_api: &(impl KVApi + ?Sized),
     key: &impl KVApiKey,
@@ -500,7 +502,10 @@ where
         return Ok(s);
     };
 
-    unreachable!("failed to get {}", key.to_key())
+    Err(MetaError::Fatal(AnyError::error(format!(
+        "failed to get {}",
+        key.to_key()
+    ))))
 }
 
 pub async fn get_object_shared_by_share_ids(

src/meta/api/src/schema_api_test_suite.rs

@@ -2374,11 +2374,13 @@ impl SchemaApiTestSuite {
         for db_id in old_id_list.iter() {
             let id_key = DatabaseId { db_id: *db_id };
             let id_mapping = DatabaseIdToName { db_id: *db_id };
+
             let meta_res: Result<DatabaseMeta, MetaError> =
                 get_kv_data(mt.as_kv_api(), &id_key).await;
+            assert!(meta_res.is_err());
+
             let mapping_res: Result<DatabaseNameIdent, MetaError> =
                 get_kv_data(mt.as_kv_api(), &id_mapping).await;
-            assert!(meta_res.is_err());
             assert!(mapping_res.is_err());
         }