fix: fix ConstColumn(String) cast to StringColumn bug

Author: lichuang

src/query/datavalues/src/columns/array/mod.rs

@@ -114,10 +114,6 @@ impl Column for ArrayColumn {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        None
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         self.data_type.clone()
     }

src/query/datavalues/src/columns/boolean/mod.rs

@@ -75,10 +75,6 @@ impl Column for BooleanColumn {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        None
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         BooleanType::new_impl()
     }

src/query/datavalues/src/columns/column.rs

@@ -31,7 +31,6 @@ use crate::TypeID;
 pub type ColumnRef = Arc<dyn Column>;
 pub trait Column: Send + Sync {
     fn as_any(&self) -> &dyn Any;
-    fn as_inner_any(&self) -> Option<&dyn Any>;
 
     /// Type of data that column contains. It's an underlying physical type:
     /// Int32 for Date, Int64 for Timestamp, so on.

src/query/datavalues/src/columns/const_/mod.rs

@@ -46,10 +46,6 @@ impl Column for ConstColumn {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        Some(self.inner().as_any())
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         self.column.data_type()
     }

src/query/datavalues/src/columns/null/mod.rs

@@ -51,10 +51,6 @@ impl Column for NullColumn {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        None
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         DataTypeImpl::Null(NullType {})
     }

src/query/datavalues/src/columns/nullable/mod.rs

@@ -94,10 +94,6 @@ impl Column for NullableColumn {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        Some(self.inner().as_any())
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         let nest = self.column.data_type();
         NullableType::new_impl(nest)

src/query/datavalues/src/columns/object/mod.rs

@@ -97,10 +97,6 @@ impl<T: ObjectType> Column for ObjectColumn<T> {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        None
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         T::data_type()
     }

src/query/datavalues/src/columns/primitive/primitive.rs

@@ -162,10 +162,6 @@ impl<T: PrimitiveType> Column for PrimitiveColumn<T> {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        None
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         create_primitive_datatype::<T>()
     }

src/query/datavalues/src/columns/series.rs

@@ -57,27 +57,14 @@ impl Series {
     }
 
     pub fn check_get<T: 'static + Column>(column: &ColumnRef) -> Result<&T> {
-        match column.as_any().downcast_ref::<T>() {
-            Some(arr) => Ok(arr),
-            None => {
-                if let Some(any_inner) = column.as_inner_any() {
-                    let arr = any_inner.downcast_ref::<T>().ok_or_else(|| {
-                        ErrorCode::UnknownColumn(format!(
-                            "downcast column error, column type: {:?}, expected column: {:?}",
-                            column.column_type_name(),
-                            std::any::type_name::<T>(),
-                        ))
-                    });
-                    arr
-                } else {
-                    Err(ErrorCode::UnknownColumn(format!(
-                        "downcast column error, column type: {:?}, expected column: {:?}",
-                        column.column_type_name(),
-                        std::any::type_name::<T>(),
-                    )))
-                }
-            }
-        }
+        let arr = column.as_any().downcast_ref::<T>().ok_or_else(|| {
+            ErrorCode::UnknownColumn(format!(
+                "downcast column error, column type: {:?}, expected column: {:?}",
+                column.column_type_name(),
+                std::any::type_name::<T>(),
+            ))
+        });
+        arr
     }
 
     pub fn check_get_mutable_column<T: 'static + MutableColumn>(

src/query/datavalues/src/columns/string/mod.rs

@@ -139,10 +139,6 @@ impl Column for StringColumn {
         self
     }
 
-    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
-        None
-    }
-
     fn data_type(&self) -> DataTypeImpl {
         StringType::new_impl()
     }