Merge pull request #7529 from TCeason/ISSUE-7528/auto_extend_ts

feat(query): auto extend datetime time part

Author: mergify[bot]

src/common/io/src/buffer/buffer_read_datetime_ext.rs

@@ -97,15 +97,27 @@ where R: BufferRead
             loop {
                 buf.clear();
                 let size = self.keep_read(&mut buf, |f| (b'0'..=b'9').contains(&f))?;
-                match get_time(&mut buf, size) {
-                    Ok(time) => times.push(time),
-                    Err(e) => return Err(e),
-                }
-                if times.len() == 3 {
+                if size == 0 {
                     break;
+                } else {
+                    let time = get_time(&mut buf, size)?;
+                    times.push(time);
+                    if times.len() == 3 {
+                        break;
+                    }
+                    self.ignore_byte(b':')?;
                 }
-                self.must_ignore_byte(b':')?;
             }
+            // Time part is HH:MM or HH or empty
+            // Examples: '2022-02-02T', '2022-02-02 ', '2022-02-02T02', '2022-02-02T3:', '2022-02-03T03:13', '2022-02-03T03:13:'
+            if times.len() < 3 {
+                times.resize(3, 0);
+                dt = tz
+                    .from_local_datetime(&d.and_hms(times[0], times[1], times[2]))
+                    .unwrap();
+                return less_1000(dt);
+            }
+
             dt = tz
                 .from_local_datetime(&d.and_hms(times[0], times[1], times[2]))
                 .unwrap();

src/common/io/tests/it/buffer/buffer_read_datetime_ext.rs

@@ -19,10 +19,14 @@ use common_io::prelude::*;
 #[test]
 fn test_read_datetime_ext() -> Result<()> {
     let mut reader = BufferReader::new(
-        "2023-03-03,2022-02-02,2009-01-01 3:2:1.123,2009-01-01 0:00:00,2009-01-01 00:00:00.123,2009-01-01 00:00:00.123456,0002-03-03T00:01:02,2022-03-04T00:01:02+08:00,2022-03-04T00:01:02-08:00,0000-00-00,0000-00-00 00:00:00,0001-01-01 00:00:00,2020-01-01T11:11:11Z,2009-01-03 00:00:00,2020-01-01T11:11:11.123Z,2055-02-03 10:00:20.234+08:00,2055-02-03 10:00:20.234-08:00,1022-05-16T03:25:02.000000+08:00".as_bytes(),
+        "2022-02-02T,2022-02-02 12,2022-02-02T13:4:,2022-02-02 12:03,2023-03-03,2022-02-02,2009-01-01 3:2:1.123,2009-01-01 0:00:00,2009-01-01 00:00:00.123,2009-01-01 00:00:00.123456,0002-03-03T00:01:02,2022-03-04T00:01:02+08:00,2022-03-04T00:01:02-08:00,0000-00-00,0000-00-00 00:00:00,0001-01-01 00:00:00,2020-01-01T11:11:11Z,2009-01-03 00:00:00,2020-01-01T11:11:11.123Z,2055-02-03 10:00:20.234+08:00,2055-02-03 10:00:20.234-08:00,1022-05-16T03:25:02.000000+08:00".as_bytes(),
     );
     let tz = Tz::UTC;
     let expected = vec![
+        "2022-02-02T00:00:00UTC",
+        "2022-02-02T12:00:00UTC",
+        "2022-02-02T13:04:00UTC",
+        "2022-02-02T12:03:00UTC",
         "2023-03-03T00:00:00UTC",
         "2022-02-02T00:00:00UTC",
         "2009-01-01T03:02:01.123UTC",

tests/logictest/suites/base/02_function/02_0012_function_datetimes

@@ -95,6 +95,54 @@ select to_datetime('9999-12-31 23:59:59');
 ----
 9999-12-31 23:59:59.000000
 
+statement query T
+select to_datetime('9999-12-31 ');
+
+----
+9999-12-31 00:00:00.000000
+
+statement query T
+select to_datetime('9999-12-31T');
+
+----
+9999-12-31 00:00:00.000000
+
+statement query T
+select to_datetime('9999-12-31 23');
+
+----
+9999-12-31 23:00:00.000000
+
+statement query T
+select to_datetime('9999-12-31 23:');
+
+----
+9999-12-31 23:00:00.000000
+
+statement query T
+select to_datetime('9999-12-31 23:59');
+
+----
+9999-12-31 23:59:00.000000
+
+statement query T
+select to_datetime('9999-12-31 23:59:');
+
+----
+9999-12-31 23:59:00.000000
+
+statement error 1010
+select to_datetime('9999-01-01 00x');
+
+statement error 1010
+select to_datetime('9999-01-01 001');
+
+statement error 1010
+select to_datetime('9999-01-01 01:123');
+
+statement error 1010
+select to_datetime('9999-01-01 01:12.123+02:00');
+
 statement error 1010
 select to_datetime('10000-01-01 00:00:00'); 
 

tests/logictest/suites/base/11_data_type/11_0001_data_type_date_time

@@ -269,12 +269,6 @@ select * from t order by id;
 2  2022-02-03 11:00:00.000000
 3  2022-02-03 11:02:01.123456
 
-statement error 1010
-insert into t values(1, '2022-02-03T');
-
-statement error 1010
-insert into t values(1, '2022-02-03 ');
-
 statement error 1010
 insert into t values(1, '2022-02-03 003:02:02');