fix: fix ConstColumn(String) cast to StringColumn bug

Author: lichuang

src/query/datavalues/src/columns/array/mod.rs

@@ -114,6 +114,10 @@ impl Column for ArrayColumn {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        Some(self.values.as_any())
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         self.data_type.clone()
     }

src/query/datavalues/src/columns/boolean/mod.rs

@@ -75,6 +75,10 @@ impl Column for BooleanColumn {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        None
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         BooleanType::new_impl()
     }

src/query/datavalues/src/columns/column.rs

@@ -31,6 +31,8 @@ use crate::TypeID;
 pub type ColumnRef = Arc<dyn Column>;
 pub trait Column: Send + Sync {
     fn as_any(&self) -> &dyn Any;
+    fn as_inner_any(&self) -> Option<&dyn Any>;
+
     /// Type of data that column contains. It's an underlying physical type:
     /// Int32 for Date, Int64 for Timestamp, so on.
     fn data_type_id(&self) -> TypeID {

src/query/datavalues/src/columns/const_/mod.rs

@@ -46,6 +46,10 @@ impl Column for ConstColumn {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        Some(self.column.as_any())
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         self.column.data_type()
     }
@@ -143,3 +147,15 @@ impl Column for ConstColumn {
         self.column.serialize(vec, 0);
     }
 }
+
+impl std::fmt::Debug for ConstColumn {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "ConstColumn \t typeid: {:?}\t len: {}\t data: [{:?}]",
+            self.data_type_id(),
+            self.len(),
+            self.column,
+        )
+    }
+}

src/query/datavalues/src/columns/null/mod.rs

@@ -51,6 +51,10 @@ impl Column for NullColumn {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        None
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         DataTypeImpl::Null(NullType {})
     }

src/query/datavalues/src/columns/nullable/mod.rs

@@ -94,6 +94,10 @@ impl Column for NullableColumn {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        Some(self.column.as_any())
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         let nest = self.column.data_type();
         NullableType::new_impl(nest)

src/query/datavalues/src/columns/object/mod.rs

@@ -97,6 +97,10 @@ impl<T: ObjectType> Column for ObjectColumn<T> {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        None
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         T::data_type()
     }

src/query/datavalues/src/columns/primitive/primitive.rs

@@ -162,6 +162,10 @@ impl<T: PrimitiveType> Column for PrimitiveColumn<T> {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        None
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         create_primitive_datatype::<T>()
     }

src/query/datavalues/src/columns/series.rs

@@ -57,14 +57,27 @@ impl Series {
     }
 
     pub fn check_get<T: 'static + Column>(column: &ColumnRef) -> Result<&T> {
-        let arr = column.as_any().downcast_ref::<T>().ok_or_else(|| {
-            ErrorCode::UnknownColumn(format!(
-                "downcast column error, column type: {:?}, expected column: {:?}",
-                column.column_type_name(),
-                std::any::type_name::<T>(),
-            ))
-        });
-        arr
+        match column.as_any().downcast_ref::<T>() {
+            Some(arr) => Ok(arr),
+            None => {
+                if let Some(any_inner) = column.as_inner_any() {
+                    let arr = any_inner.downcast_ref::<T>().ok_or_else(|| {
+                        ErrorCode::UnknownColumn(format!(
+                            "downcast column error, column type: {:?}, expected column: {:?}",
+                            column.column_type_name(),
+                            std::any::type_name::<T>(),
+                        ))
+                    });
+                    arr
+                } else {
+                    Err(ErrorCode::UnknownColumn(format!(
+                        "downcast column error, column type: {:?}, expected column: {:?}",
+                        column.column_type_name(),
+                        std::any::type_name::<T>(),
+                    )))
+                }
+            }
+        }
     }
 
     pub fn check_get_mutable_column<T: 'static + MutableColumn>(

src/query/datavalues/src/columns/string/mod.rs

@@ -139,6 +139,10 @@ impl Column for StringColumn {
         self
     }
 
+    fn as_inner_any(&self) -> Option<&dyn std::any::Any> {
+        None
+    }
+
     fn data_type(&self) -> DataTypeImpl {
         StringType::new_impl()
     }