refactor(query): remove background service (#17659)

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

* refactor(query): remove background service

Author: zhang2014

.github/actions/test_ee_standalone_background_linux/action.yml

@@ -263,24 +263,6 @@ jobs:
         with:
           name: test-stateful-standalone-linux
 
-  test_ee_standalone_background:
-    needs: [build, check]
-    runs-on: [self-hosted, X64, Linux, 2c8g, "${{ inputs.runner_provider }}"]
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/setup_bendsql
-      - uses: ./.github/actions/setup_license
-        with:
-          runner_provider: ${{ inputs.runner_provider }}
-          type: ${{ inputs.license_type }}
-      - uses: ./.github/actions/test_ee_standalone_background_linux
-        timeout-minutes: 10
-      - name: Upload failure
-        if: failure()
-        uses: ./.github/actions/artifact_failure
-        with:
-          name: test-stateful-standalone-linux
-
   #  Temporarily commented out, since this job is run on self-hosted, may
   #  bring troubles to other jobs run on self-hosted.
   #

.github/workflows/reuse.linux.yml

@@ -78,7 +78,6 @@ members = [
     "src/query/users",
     "src/query/ee_features/attach_table",
     "src/query/ee_features/vacuum_handler",
-    "src/query/ee_features/background_service",
     "src/query/ee_features/aggregating_index",
     "src/query/ee_features/data_mask",
     "src/query/ee_features/storage_encryption",
@@ -186,7 +185,6 @@ databend-common-users = { path = "src/query/users" }
 databend-common-vector = { path = "src/common/vector" }
 databend-enterprise-aggregating-index = { path = "src/query/ee_features/aggregating_index" }
 databend-enterprise-attach-table = { path = "src/query/ee_features/attach_table" }
-databend-enterprise-background-service = { path = "src/query/ee_features/background_service" }
 databend-enterprise-data-mask-feature = { path = "src/query/ee_features/data_mask" }
 databend-enterprise-fail-safe = { path = "src/query/ee_features/fail_safe" }
 databend-enterprise-hilbert-clustering = { path = "src/query/ee_features/hilbert_clustering" }

Cargo.lock

@@ -30,7 +30,6 @@ databend-common-meta-client = { workspace = true }
 databend-common-metrics = { workspace = true }
 databend-common-storage = { workspace = true }
 databend-common-tracing = { workspace = true }
-databend-enterprise-background-service = { workspace = true }
 databend-enterprise-query = { workspace = true }
 databend-query = { workspace = true }
 databend-storages-common-table-meta = { workspace = true }

Cargo.toml

@@ -31,7 +31,6 @@ use databend_common_meta_client::MIN_METASRV_SEMVER;
 use databend_common_metrics::system::set_system_version;
 use databend_common_storage::DataOperator;
 use databend_common_tracing::set_panic_hook;
-use databend_enterprise_background_service::get_background_service_handler;
 use databend_query::clusters::ClusterDiscovery;
 use databend_query::local;
 use databend_query::servers::admin::AdminService;
@@ -414,21 +413,11 @@ pub async fn start_services(conf: &InnerConfig) -> Result<(), MainError> {
         start_time.elapsed().as_secs_f32()
     );
 
-    if conf.background.enable {
-        println!("Start background service");
-        get_background_service_handler()
-            .start()
-            .await
-            .with_context(make_error)?;
-        // for one shot background service, we need to drop it manually.
-        drop(shutdown_handle);
-    } else {
-        let graceful_shutdown_timeout =
-            Some(Duration::from_millis(conf.query.shutdown_wait_timeout_ms));
-        shutdown_handle
-            .wait_for_termination_request(graceful_shutdown_timeout)
-            .await;
-    }
+    let graceful_shutdown_timeout =
+        Some(Duration::from_millis(conf.query.shutdown_wait_timeout_ms));
+    shutdown_handle
+        .wait_for_termination_request(graceful_shutdown_timeout)
+        .await;
     info!("Shutdown server.");
     log::logger().flush();
     Ok(())

scripts/ci/ci-run-ee-tests-standalone-minio-background.sh

@@ -198,9 +198,6 @@ build_exceptions! {
     EnterpriseFeatureNotEnable(1403),
     LicenseKeyExpired(1404),
 
-    BackgroundJobAlreadyExists(1501),
-    UnknownBackgroundJob(1502),
-
     InvalidRowIdIndex(1503),
     // Index related errors.
     UnsupportedIndex(1601),

src/binaries/Cargo.toml

@@ -51,8 +51,6 @@ pub enum Feature {
     Test,
     #[serde(alias = "virtual_column", alias = "VIRTUAL_COLUMN")]
     VirtualColumn,
-    #[serde(alias = "background_service", alias = "BACKGROUND_SERVICE")]
-    BackgroundService,
     #[serde(alias = "data_mask", alias = "DATA_MASK")]
     DataMask,
     #[serde(alias = "aggregate_index", alias = "AGGREGATE_INDEX")]
@@ -88,7 +86,6 @@ impl fmt::Display for Feature {
             Feature::Vacuum => write!(f, "vacuum"),
             Feature::Test => write!(f, "test"),
             Feature::VirtualColumn => write!(f, "virtual_column"),
-            Feature::BackgroundService => write!(f, "background_service"),
             Feature::DataMask => write!(f, "data_mask"),
             Feature::AggregateIndex => write!(f, "aggregate_index"),
             Feature::InvertedIndex => write!(f, "inverted_index"),
@@ -167,7 +164,6 @@ impl Feature {
             | (Feature::Vacuum, Feature::Vacuum)
             | (Feature::LicenseInfo, Feature::LicenseInfo)
             | (Feature::Stream, Feature::Stream)
-            | (Feature::BackgroundService, Feature::BackgroundService)
             | (Feature::DataMask, Feature::DataMask)
             | (Feature::InvertedIndex, Feature::InvertedIndex)
             | (Feature::VirtualColumn, Feature::VirtualColumn)
@@ -278,10 +274,6 @@ mod tests {
             Feature::VirtualColumn,
             serde_json::from_str::<Feature>("\"VIRTUAL_COLUMN\"").unwrap()
         );
-        assert_eq!(
-            Feature::BackgroundService,
-            serde_json::from_str::<Feature>("\"BackgroundService\"").unwrap()
-        );
         assert_eq!(
             Feature::DataMask,
             serde_json::from_str::<Feature>("\"DataMask\"").unwrap()
@@ -363,7 +355,6 @@ mod tests {
                 Feature::Vacuum,
                 Feature::Test,
                 Feature::VirtualColumn,
-                Feature::BackgroundService,
                 Feature::DataMask,
                 Feature::AggregateIndex,
                 Feature::InvertedIndex,
@@ -384,7 +375,7 @@ mod tests {
         };
 
         assert_eq!(
-            "LicenseInfo{ type: enterprise, org: databend, tenants: [databend_tenant,foo], features: [aggregate_index,amend_table,attach_table,background_service,compute_quota(threads_num: 1, memory_usage: 1),computed_column,data_mask,hilbert_clustering,inverted_index,license_info,storage_encryption,storage_quota(storage_usage: 1),stream,vacuum,virtual_column] }",
+            "LicenseInfo{ type: enterprise, org: databend, tenants: [databend_tenant,foo], features: [aggregate_index,amend_table,attach_table,compute_quota(threads_num: 1, memory_usage: 1),computed_column,data_mask,hilbert_clustering,inverted_index,license_info,storage_encryption,storage_quota(storage_usage: 1),stream,vacuum,virtual_column] }",
             license_info.to_string()
         );
     }