fix clippy

Author: andylokandy

src/query/codegen/Cargo.toml

@@ -20,7 +20,7 @@ common-expression = { path = "../expression" }
 
 # TODO(andylokandy): Use the version from crates.io once
 # https://github.com/reem/rust-ordered-float/pull/110 is released.
-ordered-float = { git = "https://github.com/andylokandy/rust-ordered-float.git", branch = "as", features = ["serde"] }
 itertools = "0.10"
+ordered-float = { git = "https://github.com/andylokandy/rust-ordered-float.git", branch = "as", features = ["serde"] }
 serde = { version = "1.0.137", features = ["derive"] }
 serde_json = "1.0.81"

src/query/codegen/src/writes/arithmetics_type_v2.rs

@@ -114,8 +114,8 @@ impl ResultTypeOfBinary for ({}, {}) {{
     type Modulo = {};
     type LeastSuper = {};
 }}",
-                to_primitive_str(lhs.clone()),
-                to_primitive_str(rhs.clone()),
+                to_primitive_str(*lhs),
+                to_primitive_str(*rhs),
                 to_primitive_str(add_mul),
                 to_primitive_str(minus),
                 to_primitive_str(intdiv),
@@ -157,7 +157,7 @@ impl ResultTypeOfUnary for {} {{
         Some(self % rhs)
     }}
 }}",
-                    to_primitive_str(arg.clone()),
+                    to_primitive_str(*arg),
                     to_primitive_str(negate),
                 )
                 .unwrap();
@@ -190,7 +190,7 @@ impl ResultTypeOfUnary for {} {{
         self.checked_rem(rhs)
     }}
 }}",
-                    to_primitive_str(arg.clone()),
+                    to_primitive_str(*arg),
                     to_primitive_str(negate),
                 )
                 .unwrap();

src/query/functions-v2/tests/it/scalars/arithmetic.rs

@@ -19,7 +19,6 @@ use common_expression::types::NumberDataType;
 use common_expression::Column;
 use common_expression::ColumnFrom;
 use goldenfile::Mint;
-use ordered_float::OrderedFloat;
 
 use super::run_ast;
 

src/query/functions-v2/tests/it/scalars/math.rs

@@ -19,7 +19,6 @@ use common_expression::types::NumberDataType;
 use common_expression::Column;
 use common_expression::ColumnFrom;
 use goldenfile::Mint;
-use ordered_float::OrderedFloat;
 
 use super::run_ast;
 

src/query/functions-v2/tests/it/scalars/string.rs

@@ -19,7 +19,6 @@ use common_expression::types::NumberDataType;
 use common_expression::Column;
 use common_expression::ColumnFrom;
 use goldenfile::Mint;
-use ordered_float::OrderedFloat;
 
 use super::run_ast;
 
@@ -636,13 +635,29 @@ fn test_char(file: &mut impl Write) {
     run_ast(file, "char(65, null)", &[]);
 
     let table = [
-        ("a", DataType::UInt8, Column::from_data(vec![66u8, 67])),
-        ("b", DataType::UInt8, Column::from_data(vec![98u8, 99])),
-        ("c", DataType::UInt8, Column::from_data(vec![68u8, 69])),
-        ("c2", DataType::UInt16, Column::from_data(vec![68u16, 69])),
+        (
+            "a",
+            DataType::Number(NumberDataType::UInt8),
+            Column::from_data(vec![66u8, 67]),
+        ),
+        (
+            "b",
+            DataType::Number(NumberDataType::UInt8),
+            Column::from_data(vec![98u8, 99]),
+        ),
+        (
+            "c",
+            DataType::Number(NumberDataType::UInt8),
+            Column::from_data(vec![68u8, 69]),
+        ),
+        (
+            "c2",
+            DataType::Number(NumberDataType::UInt16),
+            Column::from_data(vec![68u16, 69]),
+        ),
         (
             "a2",
-            DataType::Nullable(Box::new(DataType::UInt8)),
+            DataType::Nullable(Box::new(DataType::Number(NumberDataType::UInt8))),
             Column::from_data_with_validity(vec![66u8, 67], vec![true, false]),
         ),
     ];